feat: samples uses project.version as sdk version

[octonato]

Those changes will allows us to:

• change the sdk version in all mvn projects in one shot (changes can be pushed or not)
• samples use its own project.version as sdk version
• remove passing -D in CI, it suffice to use mvn versions:set

[octonato]

left a few comments to explain the changes

[octonato]

we don't need this anymore since #154, the archetype comes with the right version for the sdk

[octonato]

because the samples now use ${project.version} as the sdk version, it suffice to call mvn versions:set.

[raboof]

OK, so this works because we have <akkaserverless-sdk.version>${project.version}</akkaserverless-sdk.version> - which is perhaps OK for us, but would definitely be different for users.

I'm OK with it, but TBQH I don't see the advantage of using versions:set over -D for the samples. We're not publishing those, are we?

[octonato]

No, we are not publishing. But we do link them from the samples in the console. And users may checkout such a sample and run locally. In that case, we want the version to more or less aligned.

Also, if we use mvn versions:set we can from the script update the samples to run them locally for our own tests. Otherwise, we need to pass -D to maven, but then, if you want to open such a sample in intellij, you want it to have a fixed sdk version, not something to change with -D.

but would definitely be different for users.

That won't be different for users since this is just a sample. When a user starts a new project from the archetype, they get the sdk version fixed and independent from their project version.

[raboof]

we want the version to more or less aligned.

We want the SDK version in the sample to be the latest, agreed!

if you want to open such a sample in intellij, you want it to have a fixed sdk version, not something to change with -D

I can see how that's useful. Using -D means the pom.xml don't have to change all the time (marking the git repo dirty), but I guess there's no easy way to have both advantages ;)

That won't be different for users since this is just a sample.

I meant, it's a bit confusing that the sample is different from what the user actually gets when they start a new project from the archetype. Not too big of a deal though.

[octonato]

it's a bit confusing that the sample is different from what the user actually gets when they start a new project from the archetype

Yeah, it's true.
We can try to improve it. We can probably do some sed on the pom and fix the version from that same script.

[octonato]

sdk.version is enough. All artifacts must align to it.

[johanandren]

I had that on my mental note list but forgot to talk to anyone about it :)

[octonato]

With this script we can test locally, but also update the pom after a release. We don't need to do it on each release though.

[johanandren]

Neat

[octonato]

@raboof, I will merge this one as such and improve it later one using sed. I would like to have this in for now because it's useful for the current dev cycle we are in.