fix: set current sdk version using @project.version@#154
Merged
Conversation
octonato
commented
Jul 16, 2021
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
|
|
||
| <akkaserverless-sdk.version>0.7.0-beta.10</akkaserverless-sdk.version> | ||
| <akkaserverless-sdk.version>@project.version@</akkaserverless-sdk.version> |
Member
Author
There was a problem hiding this comment.
Actually we had already a solution for this, but it was not being used for the sdk version, but only for the maven-plugin version.
We want sdk, testkit and maven-plugin to use akkaserverless-sdk.version and it's now set using @project.version@.
johanandren
reviewed
Jul 16, 2021
| <groupId>com.akkaserverless</groupId> | ||
| <artifactId>akkaserverless-maven-plugin</artifactId> | ||
| <version>@project.version@</version> | ||
| <version>${D}{akkaserverless-sdk.version}</version> |
Member
Author
There was a problem hiding this comment.
This is to avoid premature substitution. It's used everywhere in this file whenever we want the archetype to have a ${var}.
However, it may not be needed. I can check it later, but don't want to change more than necessary here.
Member
Author
There was a problem hiding this comment.
johanandren
approved these changes
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.