webrtc: add FIN_ACK to close datachannels without data loss#582
Merged
achingbrain merged 7 commits intomasterfrom Oct 5, 2023
Merged
webrtc: add FIN_ACK to close datachannels without data loss#582achingbrain merged 7 commits intomasterfrom
achingbrain merged 7 commits intomasterfrom
Conversation
Specify closing datachannels by mutual agreement to ensure all data has been received by the remote before closing. Refs: #575
mxinden
reviewed
Sep 27, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
I find the introduction of a FIN_ACK a clean solution to the problem. A couple of suggestions, mostly editorial.
Co-authored-by: Max Inden <mail@max-inden.de>
sukunrt
reviewed
Sep 29, 2023
sukunrt
reviewed
Oct 3, 2023
thomaseizinger
approved these changes
Oct 4, 2023
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Great work! Some final comments.
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
2 tasks
thomaseizinger
approved these changes
Oct 5, 2023
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Great work!
No more concerns from my end.
Member
Author
|
Awesome stuff everyone! |
achingbrain
changed the title
3 tasks
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify closing datachannels by mutual agreement to ensure all data has been received by the remote before closing.
Refs: #575