fix: close webrtc streams without data loss#2073
Merged
achingbrain merged 17 commits intomasterfrom Oct 6, 2023
Merged
Conversation
achingbrain
force-pushed
the
fix/webrtc-stream-closing
branch
from
5e47bff to
005ddbf
Compare
achingbrain
changed the title
This was referenced Oct 1, 2023
Member
|
@achingbrain is this ready for review? |
Member
Author
|
@wemeetagain yes! |
maschad
reviewed
Oct 4, 2023
Member
maschad
left a comment
maschad
left a comment
There was a problem hiding this comment.
Looks good so far, left some comments.
Chrome does not always send all messages after closing a datachannel even if `bufferedAmount` is `0` before closing. This PR adds a `FIN_ACK` message that is sent in reply to a `FIN` message - because all messages are send in-order, when this is received we know the remote has received all of our data messages and it's safe to close the channel.
wemeetagain
reviewed
Oct 5, 2023
maschad
approved these changes
Oct 5, 2023
Member
maschad
left a comment
maschad
left a comment
There was a problem hiding this comment.
Great job on this, one minor comment. lgtm
Co-authored-by: Chad Nehemiah <[email protected]>
achingbrain
changed the title
achingbrain
added a commit
that referenced
this pull request
Oct 6, 2023
- Gracefully close streams on muxer shutdown - Refactor initiator/recipient flows for clarity - Wait for `bufferedAmount` to be `0` before closing a datachannel - Close datachannels on both initiator and recipient - Implements FIN_ACK for closing datachannels without data loss Supersedes #2048 --------- Co-authored-by: Chad Nehemiah <[email protected]>
This was referenced Oct 10, 2023
This was referenced Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bufferedAmountto be0before closing a datachannelSupersedes #2048
Depends on: