feat: add rust-libp2p-server to monorepo#4311
Merged
mergify[bot] merged 35 commits intomasterfrom Aug 21, 2023
Merged
Conversation
Moves https://github.com/mxinden/rust-libp2p-server to the rust-libp2p monorepository. > # Rust libp2p Server > > A rust-libp2p based server implementation running: > > - the [Kademlia protocol](https://github.com/libp2p/specs/tree/master/kad-dht) > > - the [Circuit Relay v2 protocol](https://github.com/libp2p/specs/blob/master/relay/circuit-v2.md) > > - the [AutoNAT protocol](https://github.com/libp2p/specs/blob/master/autonat/README.md)
4 tasks
mxinden
commented
Aug 10, 2023
mxinden
commented
Aug 10, 2023
With #4165 fixed, there is no need for filtering ipv6 quic.
mxinden
commented
Aug 14, 2023
Member
Author
|
@thomaseizinger this is ready for a first review when you have time. |
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Looking forward to this!
4 tasks
Member
Author
|
@thomaseizinger anything else missing here from your end? I would like to merge in order to not maintain both https://github.com/mxinden/rust-libp2p-server/ and this pull request and to be able to continuously deploy again to our staging server. |
thomaseizinger
approved these changes
Aug 18, 2023
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
A few more comments, nothing blocking :)
Contributor
|
Haha dang, I think you'll have to add an exception that this crate is allowed to depend on |
Co-authored-by: Thomas Eizinger <[email protected]>
Co-authored-by: Thomas Eizinger <[email protected]>
Co-authored-by: Thomas Eizinger <[email protected]>
mxinden
added a commit
that referenced
this pull request
Sep 1, 2023
Current approach is not robust to more complex branch names. See context in #4311 (comment)
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Current approach is not robust to more complex branch names. Related #4311 (comment). Pull-Request: #4421.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves https://github.com/mxinden/rust-libp2p-server to the rust-libp2p monorepository.
Notes & open questions
Fixes mxinden/rust-libp2p-server#253.
Change checklist