fix(quic): allow listening on ipv4 and ipv6 separately#4289
fix(quic): allow listening on ipv4 and ipv6 separately#4289mergify[bot] merged 11 commits intolibp2p:masterfrom
Conversation
simultaneously
jxs
changed the title
thomaseizinger
changed the title
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Also needs a changelog entry. Is there an easy way to test this? I think attempting to listen on the same port should do it right? We don't actually have to establish connections so it should be a fairly small test :)
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Also needs a changelog entry. Is there an easy way to test this? I think attempting to listen on the same port should do it right? We don't actually have to establish connections so it should be a fairly small test :)
Thanks, updated changelog and added a test ptal Thomas.
thomaseizinger
changed the title
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
A few more things, otherwise LGTM!
Thanks @jxs! :)
|
@jxs The lockfile doesn't seem to be up-to-date. |
|
Thanks for the ping Thomas, updated! |
|
can we release 0.9.1-alpha @mxinden? I can then submit a PR to your |
Just created #4312.
No need. Will be included in the monorepo soon. See #4311. |
Following #4289 (comment), hereby is the PR to also improve the `create_socket` using [`for_addr`](https://docs.rs/socket2/latest/socket2/struct.Domain.html#method.for_address). We also add a test for listening on IPv4 and IPv6 separately. Pull-Request: #4328.
3 participants
Description
Resolves #4165.
Notes & open questions
Should we also add a test for this?
Change checklist