core/muxing: Rename close to poll_close#2666
Merged
mxinden merged 3 commits intolibp2p:masterfrom May 29, 2022
Merged
Conversation
thomaseizinger
changed the title
close to poll_closeclose to poll_close
27 tasks
It is common practise to prefix functions that return a `Poll` with `poll_`.
thomaseizinger
force-pushed
the
refactor/poll-close
branch
from
f2e4dcd to
6d05be4
Compare
thomaseizinger
requested review from
elenaf9 and
mxinden
and removed request for
elenaf9
mxinden
reviewed
May 29, 2022
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It is common practise to prefix functions that return a
Pollwithpoll_.Links to any relevant issues
StreamMuxertrait #2648.Open Questions
Change checklist