Skip to content

Fix raw pointer ref, done by Cursor#70

Closed
edwardalee wants to merge 2 commits intomainfrom
fix-raw-pointer-ref
Closed

Fix raw pointer ref, done by Cursor#70
edwardalee wants to merge 2 commits intomainfrom
fix-raw-pointer-ref

Conversation

@edwardalee
Copy link
Contributor

@edwardalee edwardalee commented Jun 10, 2025

This PR provides a potential fix to a compile error that started spontaneously appearing on June 8, 2025, which had the following form:

lfc: error: implicit autoref creates a reference to the dereference of a raw pointer [big.rs:149:36]
...
lfc: error: implicit autoref creates a reference to the dereference of a raw pointer [banking.rs:157:36]

The fix is provided by Cursor.

Unfortunately, this does not fix the problem.
So this PR disables the Rust benchmark tests altogether.

@edwardalee edwardalee requested a review from cmnrd June 10, 2025 06:41
@oowekyala
Copy link
Contributor

Can you point me to a place where the compile error is visible? And also what is cursor?

There is no raw pointer here so if cursor is some kind of linter it is wrong. The dereference is calling this implementation which is completely safe, so adding unsafe blocks is not needed here...

@edwardalee
Copy link
Contributor Author

You can find the error here:

https://github.com/lf-lang/lingua-franca/actions/runs/15530831589/job/43719285633?pr=2515

and in every other PR to lingua-franca that has run tests in the last couple of days.
Cursor is an AI-enabled IDE based on VS Code.

@oowekyala
Copy link
Contributor

oowekyala commented Jun 10, 2025

lf-lang/reactor-rs#53 would fix the issue. But we need to bump the reactor runtime version in lf-lang/lingua-franca I suspect.

To avoid future issues like this we shouldn't just download the latest nightly rust in CI. We should run with a set version. Edit: this is the place:

@edwardalee
Copy link
Contributor Author

This is fixed instead in lf-lang/reactor-rs#53

@edwardalee edwardalee closed this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants