Revise DtoDeclarationExp() #5032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
force-pushed
the
rm_DtoDeclarationExp
branch
from
e7cb7d4 to
adeb138
Compare
kinke
force-pushed
the
rm_DtoDeclarationExp
branch
from
adeb138 to
ecc0364
Compare
After comparing this with DMD's `Dsymbol_toElem()`, incl. checking the VarDeclaration overloads of the codegen visitors.
kinke
force-pushed
the
rm_DtoDeclarationExp
branch
from
ecc0364 to
8768a50
Compare
kinke
commented
Dec 16, 2025
|
|
||
| if (auto vd = e->declaration->isVarDeclaration()) { | ||
| if (!vd->isDataseg() && vd->needsScopeDtor()) { | ||
| pushVarDtorCleanup(p, vd); |
Member
Author
There was a problem hiding this comment.
This check was insufficient, as it turned out during intermediate refactorings - IIRC, missing temporaries inside an outer align(N) declaration (as e->declaration).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After comparing this with DMD's
Dsymbol_toElem(), incl. checking theVarDeclarationoverloads of the codegen visitors.