Skip to content

Conversation

@kinke
Copy link
Member

@kinke kinke commented Dec 5, 2025

No description provided.

thewilsonator and others added 30 commits July 22, 2025 17:31
* Make `Dysmbol.size()` return a `ulong`

instead of a `uinteger_t`. Mangling is not a problem for return types, and this allows up to remove some `import dmd.globals;`

* Move `Ungag` to `dsymbolsem.d`
…r when (dlang/dmd!21616)

appending to a large array that could potentially use extend, when the
requested array size is within a certain size for a multiple of pages.

The calculation had the wrong sign for the large padding (the 2 size_t +
1 byte), which made it end up sending a number very close to size_t.max
  into the extend function.

This affected both appending and setting length performance, though
appending also had a grow factor which may have mitigated this somewhat.
As pointed out in dlang/dmd!21249, Musl doesn't implement *64 versions of these
functions because off_t is always 64 bits. However there are aliases
defined if `_USE_LARGEFILE64_SOURCE` is true.
The musl definition can be found at
https://git.musl-libc.org/cgit/musl/tree/include/sched.h?id=8fd5d031876345e42ae3d11cc07b962f8625bc3b#n19

Tested that the struct has the correct size on x86_64 and x86 musl
with and without -version=CRuntime_Musl_Pre_Time64

Signed-off-by: Andrei Horodniceanu <[email protected]>
@kinke
Copy link
Member Author

kinke commented Dec 9, 2025

Almost green; AFAICT just need to check:

  • compilable/fix19983.c: duplicate extern variable declarations in the same C scope
  • Win64: runnable/testpdb.d
  • AArch64: std.internal.math.gammafunction unittests (possibly macOS only with 64-bit real)
  • Linux AArch64: druntime-test-exceptions failing, null-pointer-read doesn't seem to end up in the signal handler (maybe just a CI virtualization issue?)

@kinke
Copy link
Member Author

kinke commented Dec 11, 2025

I guess compilable/fix19983.c needs a working #4491.

Edit: And #5032.

@kinke kinke force-pushed the merge_stable branch 2 times, most recently from d7cab3c to d18e7c9 Compare December 16, 2025 16:56
Fixes druntime-test-importc_compare for Apple targets, which depends
on the new predefined version.
@kinke kinke marked this pull request as ready for review December 17, 2025 11:02
@kinke kinke merged commit 4082d3f into ldc-developers:master Dec 17, 2025
20 of 21 checks passed
@kinke kinke deleted the merge_stable branch December 17, 2025 12:03
@kinke kinke mentioned this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.