Skip to content

Conversation

@personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request simplifies the error output from the OneNote importer:

  • Removes a stack trace that always points to the same file: Previously, most importer errors included an identical stack trace pointing to onenote-converter\renderer\pkg\renderer.js (see, for example, this forum post).
  • Removes a file path: Previously, error output included the absolute path to an Errors.html file. This full path is unnecessary and doesn't help with debugging.

Note

This pull request targets release-3.5.

Testing plan

  1. Patch the OneNote importer to simulate an import failure:

    diff
    diff --git a/packages/onenote-converter/parser/src/onenote/page.rs b/packages/onenote-converter/parser/src/onenote/page.rs
    index 8a420f7df..c5b122ce4 100644
    --- a/packages/onenote-converter/parser/src/onenote/page.rs
    +++ b/packages/onenote-converter/parser/src/onenote/page.rs
    @@ -202,6 +202,10 @@ pub(crate) fn parse_page(page_space: ObjectSpaceRef) -> Result<Page> {
         let page_title = extract_text_from_title(&title);
         set_current_page(page_title);
     
    +    if true {
    +        return Err(ErrorKind::MalformedData("Test...".into()).into());
    +    }
    +
         let level = metadata.page_level;
     
         let contents = data
  2. Import a OneNote notebook.

  3. Verify that the "There were some errors importing the notes" dialog is shown.

  4. Verify that the "send bug report" button pre-fills a Joplin Forum template.

  5. Verify that the Joplin Forum template does not include redundant stack trace output.

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: OneNote importer: Simplify error reports Desktop: OneNote importer: Simplify error report Jan 10, 2026
@laurent22 laurent22 merged commit e19e1ac into laurent22:release-3.5 Jan 10, 2026
11 checks passed
@personalizedrefrigerator personalizedrefrigerator deleted the pr/desktop/onenote-import/simplify-error-report branch January 12, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants