Desktop: OneNote importer: Simplify error report #14074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request simplifies the error output from the OneNote importer:
onenote-converter\renderer\pkg\renderer.js(see, for example, this forum post).Errors.htmlfile. This full path is unnecessary and doesn't help with debugging.Note
This pull request targets
release-3.5.Testing plan
Patch the OneNote importer to simulate an import failure:
diff
Import a OneNote notebook.
Verify that the "There were some errors importing the notes" dialog is shown.
Verify that the "send bug report" button pre-fills a Joplin Forum template.
Verify that the Joplin Forum template does not include redundant stack trace output.