Desktop: OneNote importer: Simplify error report (#14074)

Author: personalizedrefrigerator

packages/app-desktop/gui/WindowCommandsAndDialogs/commands/importFrom.ts

@@ -124,8 +124,7 @@ export const runtime = (control: WindowControl): CommandRuntime => {
 
 					void CommandService.instance().execute('showModalMessage', `${modalMessage}\n\n${statusStrings.join('\n')}`);
 				},
-				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
-				onError: (error: any) => {
+				onError: (error: string|Error) => {
 					errors.push(error);
 					console.warn(error);
 				},

packages/lib/services/interop/InteropService_Importer_OneNote.ts

@@ -110,7 +110,10 @@ export default class InteropService_Importer_OneNote extends InteropService_Impo
 			try {
 				await oneNoteConverter(notebookFilePath, resolve(outputDirectory2), notebookBaseDir);
 			} catch (error) {
-				this.options_.onError?.(error);
+				// Forward only the error message. Usually the stack trace points to bytes in the WASM file.
+				// It's very difficult to use and can cause the error report to be longer than the maximum
+				// length for auto-creating a forum post:
+				this.options_.onError?.(error.message ?? error);
 				console.error(error);
 			}
 		}

packages/onenote-converter/renderer/src/section.rs

@@ -16,6 +16,8 @@ pub(crate) struct RenderedSection {
     pub(crate) section_dir: String,
 }
 
+const ERRORS_NOTE_NAME: &str = "⚠️ Errors ⚠️";
+
 impl Renderer {
     pub fn new() -> Self {
         Renderer {
@@ -81,11 +83,11 @@ impl Renderer {
         let toc_path = self.write_html_file(&output_dir, section.display_name(), &toc_html)?;
         log!("ToC: {}", toc_path);
 
-        if let Some(errors_path) = errors_path {
+        if errors_path.is_some() {
             Err(ErrorKind::RenderFailed(format!(
                 "Some pages failed to render. First error: {:?}. Full error report written to {}",
                 errors.first(),
-                errors_path
+                ERRORS_NOTE_NAME,
             ))
             .into())
         } else {
@@ -136,7 +138,7 @@ impl Renderer {
         Ok(TocEntry {
             level: 1,
             is_error: true,
-            name: "⚠️ Errors ⚠️".into(),
+            name: ERRORS_NOTE_NAME.into(),
             relative_path: fs_driver().remove_prefix(&errors_path, &output_dir).into(),
         })
     }