Desktop: OneNote import: Fix video embeds aren't imported: Import video embeds as links #14046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
personalizedrefrigerator
changed the title
personalizedrefrigerator
added
desktop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request works around an import issue by importing
<video>embeds in OneNote notebooks as<a>links. Previously,<video>embeds were imported as unplayable videos with a missing resource.Partially resolves #13549.
Notes
A better fix might be to add support for
<video>resources in HTML notes. Currently, the HTML importer doesn't import<video>markup as resources (see #13899) and the HTML->HTML renderer doesn't support rendering<video>s that reference HTML resources.Testing plan