Desktop,Cli: Import: Fix video files are not imported as resources#13899
Closed
personalizedrefrigerator wants to merge 3 commits intolaurent22:devfrom
Closed
Conversation
Collaborator
Author
|
Closing for now — imported video files don't export correctly (or render in the note viewer). More work will need to be done before this change is ready for review/merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue in which
<video src="./path/to/file">did not result in./path/to/filebeing imported as a resource (as it would be for<imgs and<as).Important
Joplin is still unable to render the imported video files, as
<video src=":/someresourceid">markup seems to currently be unsupported. For videos to play, it seems to currently be necessary to convert imported HTML to Markdown, then manually replace the<videotags with[resource links].It may make sense to add support for rendering videos from local resources in this or a follow-up pull request.
Partially resolves #13549.
Testing
<video controls src=":/...">with a[resource link](:/...).