Desktop,Mobile,Cli: Fixes #13522: Fix "cannot add an item as a child of a read-only item" error when updating share IDs

packages/lib/models/BaseItem.ts

@@ -1007,7 +1007,7 @@ export default class BaseItem extends BaseModel {
 
 		const isNew = this.isNew(o, options);
 
-		if (needsShareReadOnlyChecks(this.modelType(), options.changeSource, this.syncShareCache)) {
+		if (needsShareReadOnlyChecks(this.modelType(), options.changeSource, this.syncShareCache, options.disableReadOnlyCheck)) {
 			if (!isNew) {
 				const previousItem = await this.loadItemByTypeAndId(this.modelType(), o.id, { fields: ['id', 'share_id'] });
 				checkIfItemCanBeChanged(this.modelType(), options.changeSource, previousItem, this.syncShareCache);

packages/lib/models/Folder.sharing.test.ts

@@ -1,4 +1,4 @@
-import { setupDatabaseAndSynchronizer, switchClient, createFolderTree, supportDir, msleep, resourceService } from '../testing/test-utils';
+import { setupDatabaseAndSynchronizer, switchClient, createFolderTree, supportDir, msleep, resourceService, simulateReadOnlyShareEnv } from '../testing/test-utils';
 import Folder from '../models/Folder';
 import { allNotesFolders } from '../testing/test-utils-synchronizer';
 import Note from '../models/Note';
@@ -181,6 +181,21 @@ describe('models/Folder.sharing', () => {
 		}
 	}));
 
+	it('should not fail to update share IDs when an outdated share ID is contained in a read-only folder', async () => {
+		const shareId = 'abcd1234';
+		const root = await Folder.save({ title: 'read-only', share_id: shareId });
+		// Save a child with a different share ID
+		const child = await Note.save({ title: 'Test', parent_id: root.id, share_id: `${shareId}-different` });
+
+		const reset = simulateReadOnlyShareEnv([shareId]);
+		try {
+			await Folder.updateAllShareIds(resourceService(), []);
+			expect(await Note.load(child.id)).toMatchObject({ share_id: shareId });
+		} finally {
+			reset();
+		}
+	});
+
 	it('should unshare a subfolder of a shared folder when it is moved to the root', (async () => {
 		let folder1 = await createFolderTree('', [
 			{

packages/lib/models/Folder.ts

@@ -556,7 +556,10 @@ export default class Folder extends BaseItem {
 				share_id: row.share_id || '',
 				parent_id: row.parent_id,
 				updated_time: Date.now(),
-			}, { autoTimestamp: false });
+			}, {
+				autoTimestamp: false,
+				disableReadOnlyCheck: true,
+			});
 		}
 	}