Desktop,Mobile,Cli: Fixes #13522: Fix "cannot add an item as a child of a read-only item" error when updating share IDs#13523
Merged
laurent22 merged 1 commit intolaurent22:devfrom Oct 28, 2025
Conversation
… a child of a read-only item" error when updating share IDs
| }, { autoTimestamp: false }); | ||
| }, { | ||
| autoTimestamp: false, | ||
| disableReadOnlyCheck: true, |
Collaborator
Author
There was a problem hiding this comment.
Note: This may lead to conflicts:
joplin/readme/dev/spec/read_only.md
Line 24 in 94725c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an error related to read-only shares by disabling a "not read-only" assertion when updating
share_ids (e.g. if theshare_ids were invalid due to an incomplete sync or issue elsewhere). Previously, if oneshare_idfailed to update, calls toupdateAllShareIdscould fail. This prevented sharing new notebooks.Fixes #13522.
Testing
This pull request includes an automated test that failed previously.
I have verified that: