Skip to content

Comments

Desktop,Mobile,Cli: Fixes #13522: Fix "cannot add an item as a child of a read-only item" error when updating share IDs#13523

Merged
laurent22 merged 1 commit intolaurent22:devfrom
personalizedrefrigerator:pr/desktop/fix-sync-readonly-error
Oct 28, 2025
Merged

Desktop,Mobile,Cli: Fixes #13522: Fix "cannot add an item as a child of a read-only item" error when updating share IDs#13523
laurent22 merged 1 commit intolaurent22:devfrom
personalizedrefrigerator:pr/desktop/fix-sync-readonly-error

Conversation

@personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Oct 23, 2025

Summary

This pull request fixes an error related to read-only shares by disabling a "not read-only" assertion when updating share_ids (e.g. if the share_ids were invalid due to an incomplete sync or issue elsewhere). Previously, if one share_id failed to update, calls to updateAllShareIds could fail. This prevented sharing new notebooks.

Fixes #13522.

Testing

This pull request includes an automated test that failed previously.

I have verified that:

  • It's possible to share a notebook without the "read-only share" error in my test environment.

… a child of

a read-only item" error when updating share IDs
}, { autoTimestamp: false });
}, {
autoTimestamp: false,
disableReadOnlyCheck: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This may lead to conflicts:

- If a local read-only item has been modified, and the synchroniser tries to upload it, Joplin Cloud responds with a read-only error. The synchroniser local item is copied to the conflict folder and the remote item overwrites the local one.

@personalizedrefrigerator personalizedrefrigerator marked this pull request as ready for review October 27, 2025 15:24
@laurent22 laurent22 merged commit b25e181 into laurent22:dev Oct 28, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharing a new folder: Error: "Cannot add an item as a child of a read-only item"

2 participants