Skip to content

fix: report SDK version in resource attributes #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vadman97 merged 3 commits into from
Oct 29, 2025
Merged

fix: report SDK version in resource attributes #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e06550
fix: report SDK version in resource attributes
Vadman97 Oct 29, 2025
bf5b01e
auto update file
Vadman97 Oct 29, 2025
dd84f1a
fix type
Vadman97 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/LaunchDarklyObservability/Plugin/Observability.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ public final class Observability: Plugin {
resourceAttributes[SemanticConvention.highlightProjectId] = .string(mobileKey)
resourceAttributes[SemanticConvention.serviceName] = .string(options.serviceName)
resourceAttributes[SemanticConvention.serviceVersion] = .string(options.serviceVersion)

resourceAttributes[SemanticConvention.telemetryDistroName] = .string("swift-launchdarkly-observability")
resourceAttributes[SemanticConvention.telemetryDistroVersion] = .string(sdkVersion)

customHeaders[SemanticConvention.highlightProjectId] = mobileKey

options.resourceAttributes = resourceAttributes
Expand Down
2 changes: 2 additions & 0 deletions Sources/LaunchDarklyObservability/Version.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// This file is automatically updated by release-please. Do not edit manually.
public let sdkVersion = "x-release-please-version"
2 changes: 2 additions & 0 deletions Sources/Observability/Api/SemanticConvention.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ public enum SemanticConvention {
public static let attributeSamplingRatio = "launchdarkly.sampling.ratio"
public static let launchdarklySdkVersion = "launchdarkly.sdk.version"
public static let highlightProjectId = "highlight.project_id"
public static let telemetryDistroName = "telemetry.distro.name"
public static let telemetryDistroVersion = "telemetry.distro.version"
public static let serviceName = "service.name"
public static let serviceVersion = "service.version"
public static let serviceNamespace = "service.namespace"
Expand Down
5 changes: 4 additions & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
"package-name": "swift-launchdarkly-observability",
"release-type": "simple",
"versioning": "default",
"bump-minor-pre-major": true
"bump-minor-pre-major": true,
"extra-files": [
"Sources/LaunchDarklyObservability/Version.swift"
]
}
}
}