fix: report SDK version in resource attributes #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelonogov-ld
approved these changes
Oct 29, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
abelonogov-ld
approved these changes
Oct 29, 2025
Vadman97
force-pushed
the
vadim/resource-attrs
branch
from
fdcbcc6 to
dd84f1a
Compare
Vadman97
added a commit
that referenced
this pull request
Oct 29, 2025
Vadman97
added a commit
that referenced
this pull request
Oct 29, 2025
Correctly use `x-release-please-version` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Set `sdkVersion` to 0.8.0 and expand repository CODEOWNERS. > > - **Versioning**: > - Update `Sources/LaunchDarklyObservability/Version.swift` to set `sdkVersion` to `"0.8.0"`. > - **Repo settings**: > - Expand `CODEOWNERS` to include `@abelonogov-ld` and `@mario-launchdarkly`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 31045e0. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
abelonogov-ld
pushed a commit
that referenced
this pull request
Nov 1, 2025
🤖 I have created a release *beep* *boop* --- ## [0.8.1](0.8.0...0.8.1) (2025-10-29) ### Bug Fixes * report SDK version in resource attributes ([#63](#63)) ([8a79ddb](8a79ddb)) * report SDK version in resource attributes (fixup! [#63](#63)) ([#65](#65)) ([14a5cbe](14a5cbe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release 0.8.1: bump sdkVersion and manifest version, and update CHANGELOG with bug fixes for reporting SDK version in resource attributes. > > - **Release** > - Bump `sdkVersion` to `0.8.1` in `Sources/LaunchDarklyObservability/Version.swift`. > - Update `.release-please-manifest.json` to `0.8.1`. > - **Docs** > - Update `CHANGELOG.md` with 0.8.1 bug fixes (report SDK version in resource attributes). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 79557e6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds telemetry distro name/version resource attributes and introduces a release-managed sdkVersion, updating config to track it.
Sources/LaunchDarklyObservability/Plugin/Observability.swift):resourceAttributesfortelemetry.distro.nameandtelemetry.distro.version(fromsdkVersion).Sources/Observability/Api/SemanticConvention.swift):telemetry.distro.name,telemetry.distro.version.Sources/LaunchDarklyObservability/Version.swiftwithsdkVersionplaceholder managed by release-please.release-please-config.jsonto include this file underextra-files.Written by Cursor Bugbot for commit dd84f1a. This will update automatically on new commits. Configure here.