feat: support non-standard windows added by WindowManager #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelonogov-ld
force-pushed
the
andrey/nonstandard-views
branch
from
664244c to
b117d79
Compare
agrognetti
approved these changes
Dec 2, 2025
e2e/android/app/src/main/java/com/example/androidobservability/masking/XMLMaskingActivity.kt
Outdated
Show resolved
Hide resolved
e2e/android/app/src/main/java/com/example/androidobservability/masking/XMLMaskingActivity.kt
Show resolved
Hide resolved
e2e/android/app/src/main/java/com/example/androidobservability/masking/XMLMaskingActivity.kt
Outdated
Show resolved
Hide resolved
e2e/android/app/src/main/java/com/example/androidobservability/masking/XMLMaskingActivity.kt
Outdated
Show resolved
Hide resolved
e2e/android/app/src/main/java/com/example/androidobservability/masking/XMLMaskingActivity.kt
Outdated
Show resolved
Hide resolved
...ity-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/WindowEntry.kt
Outdated
Show resolved
Hide resolved
...ity-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/capture/WindowEntry.kt
Show resolved
Hide resolved
Merged
abelonogov-ld
added a commit
that referenced
this pull request
Dec 2, 2025
* main: feat: support non-standard windows added by WindowManager (#306)
abelonogov-ld
added a commit
that referenced
this pull request
Dec 2, 2025
* andrey/mask-collector: remove ressurectued import feat: support non-standard windows added by WindowManager (#306)
abelonogov-ld
added a commit
that referenced
this pull request
Dec 4, 2025
* main: (85 commits) doc: Add using ldMask in readme. (#311) chore: release main (#312) feat: take transformed coordinates, which are more precise in animation (#309) chore: release main (#307) fix(SEC-7530): update react-server-dom-webpack to 19.0.1 (#310) feat: recursive mask collection (#308) feat: support non-standard windows added by WindowManager (#306) feat: Android SR Do not send duplicate screens (#304) test: Add UI and logic to evaluate boolean flags (#305) chore: release main (#303) feat: Android Dialog Capture (#302) chore: Update Android Test main screen (#301) chore: release main (#300) feat: XML Views Automasking options (#299) fix: missed imports (#298) chore: release main (#297) feat: Support ldMask() for Native and Compose views. (#295) chore: release main (#296) fix: tweaks Android InteractionDetector to delegate additional defaul… (#294) chore: release main (#293) ... # Conflicts: # e2e/react-router/src/ldclientLazy.tsx # e2e/react-router/src/routes/root.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?
Are there any deployment considerations?
Note
Add floating/attached dialog examples and switch capture logic to use WindowManager.LayoutParams with PixelCopy candidacy checks.
wmTypewithlayoutParams; addisPixelCopyCandidate()(excludes non-activity,TYPE_APPLICATION_STARTING, andFLAG_SECURE).layoutParams.type; use PixelCopy only whenwindowEntry.isPixelCopyCandidate().WindowEntrywithlayoutParamswhile preservingdetermineWindowTypebehavior.WindowEntryTestcovering PixelCopy candidacy rules.FloatingPopupViewand buttons to show floating popup (TYPE_APPLICATION_PANEL) and attached dialog (TYPE_APPLICATION_ATTACHED_DIALOG).activity_masking_bench.xmlwith new controls.Written by Cursor Bugbot for commit 31bb519. This will update automatically on new commits. Configure here.