feat: XML Views Automasking options #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* andrey/compilation-fix: missed imports chore: release main (#297)
Vadman97
approved these changes
Nov 21, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: ldMask modifier ignored when matchers list empty
The condition checks maskMatchers.isNotEmpty() instead of sensitiveComposeRects.isNotEmpty() before applying masking. This causes views marked with the ldMask() modifier to not be masked when the matchers list is empty, even though the sensitive areas were collected. The ldMask() modifier should work independently of configured matchers.
sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/CaptureSource.kt#L156-L161
...ndroid/lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/NativeMaskTarget.kt
Outdated
Show resolved
Hide resolved
abelonogov-ld
changed the title
...lib/src/main/kotlin/com/launchdarkly/observability/replay/masking/SensitiveAreasCollector.kt
Show resolved
Hide resolved
Merged
abelonogov-ld
pushed a commit
that referenced
this pull request
Nov 22, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-android: 0.16.0</summary> ## [0.16.0](launchdarkly-observability-android-0.15.0...launchdarkly-observability-android-0.16.0) (2025-11-22) ### Features * XML Views Automasking options ([#299](#299)) ([c61a7be](c61a7be)) ### Bug Fixes * missed imports ([#298](#298)) ([6e6c388](6e6c388)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release `observability-android` 0.16.0 with XML Views automasking and an import fix; update manifest and gradle version. > > - **SDK `observability-android`**: > - Bump version to `0.16.0` in `sdk/@launchdarkly/observability-android/gradle.properties` and `.release-please-manifest.json`. > - Update `CHANGELOG.md`: > - Features: XML Views automasking options. > - Bug Fixes: missed imports. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d827ba6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
abelonogov-ld
added a commit
that referenced
this pull request
Dec 4, 2025
* main: (85 commits) doc: Add using ldMask in readme. (#311) chore: release main (#312) feat: take transformed coordinates, which are more precise in animation (#309) chore: release main (#307) fix(SEC-7530): update react-server-dom-webpack to 19.0.1 (#310) feat: recursive mask collection (#308) feat: support non-standard windows added by WindowManager (#306) feat: Android SR Do not send duplicate screens (#304) test: Add UI and logic to evaluate boolean flags (#305) chore: release main (#303) feat: Android Dialog Capture (#302) chore: Update Android Test main screen (#301) chore: release main (#300) feat: XML Views Automasking options (#299) fix: missed imports (#298) chore: release main (#297) feat: Support ldMask() for Native and Compose views. (#295) chore: release main (#296) fix: tweaks Android InteractionDetector to delegate additional defaul… (#294) chore: release main (#293) ... # Conflicts: # e2e/react-router/src/ldclientLazy.tsx # e2e/react-router/src/routes/root.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support maskText, maskTextInput, maskSensitive for Android Native XML Views
How did you test this change?
Are there any deployment considerations?
Note
Adds auto-masking for Android XML views and refactors masking to a new MaskTarget/MaskMatcher API, updating capture/instrumentation and e2e demo package paths.
replay/masking: introduceMaskTarget/MaskMatcher,ComposeMaskTarget,NativeMaskTarget(handlesEditText/TextView, passwords, hints, contentDescription), andSensitiveAreasCollector(now usesLDLogger).PrivacyProfilematchers rewritten to operate onMaskTarget(textInput,text,sensitive).CaptureSourcenow acceptsLDLoggerand uses newmasking.SensitiveAreasCollector;ReplayInstrumentationcreates logger and passes it toCaptureSource.replay/MaskMatcher.ktand oldSensitiveAreasCollector.com.example.androidobservability.smoothie; updateAndroidManifest.xml,MainActivity, and adapter imports.SmoothieAdapter: callldMask()on image view to mark as sensitive.Written by Cursor Bugbot for commit 60a4713. This will update automatically on new commits. Configure here.