feat: Support ldMask() for Native and Compose views. by abelonogov-ld · Pull Request #295 · launchdarkly/observability-sdk

abelonogov-ld · 2025-11-19T20:04:42Z

Summary

Support ldMask() for Native and Compose views.
a. Native

  view.ldMask()

b. Compose

 modifier = Modifier.ldMask()

2 XML screens: Fruta and Credit Card
Make Compose User form rotate

How did you test this change?

Test SR using RRWeb player on SecondaryActivity, Fruta(XML), Credit Card

Note

Adds ldMask for native Views and Compose, introduces SensitiveAreasCollector to mask captured regions, and includes new Credit Card and Smoothie sample screens.

SDK / Session Replay:
- Masking API: Add View.ldMask()/ldUnmask() and Modifier.ldMask()/ldUnmask() in MaskingViewAPI.kt; define LdMaskSemanticsKey.
- Sensitive Area Detection: Introduce SensitiveAreasCollector to gather sensitive rects from Compose semantics and native View tags; add view_tags.xml ids.
- Capture Pipeline: Refactor CaptureSource to use SensitiveAreasCollector and apply gray masking over returned rects.
E2E App:
- New Screens (XML): Add CreditCardActivity and SmoothieListActivity with layouts (activity_credit_card.xml, activity_smoothie_list.xml, item_smoothie.xml) and SmoothieAdapter; register in AndroidManifest.xml and add launch buttons in MainActivity.
- Compose Demo: Update SecondaryActivity to use Modifier.ldMask() on header and animate rotation of the address card.
- UI/Dependencies: Switch theme to Theme.Material3.DayNight.NoActionBar; add androidx.recyclerview:recyclerview dependency.

^{Written by Cursor Bugbot for commit f04c7eb. This will update automatically on new commits. Configure here.}

tanderson-ld · 2025-11-20T15:09:38Z

I did a high level review and don't have any concerns. Due to my bandwidth constraints, I think @agrognetti will have to be primary reviewer.

Vadman97

looks reasonable to me!

agrognetti · 2025-11-21T15:53:51Z

@@ -0,0 +1,49 @@
+package com.smoothie


This package should be inside com.example.androidobservability (The whole code of the app goes there - unless you use different modules, which is not the case)

agrognetti · 2025-11-21T15:57:31Z

@@ -0,0 +1,48 @@
+package com.smoothie


Same here https://github.com/launchdarkly/observability-sdk/pull/295/files#r2550221149

agrognetti · 2025-11-21T16:00:55Z

This file shouldn't be committed

agrognetti · 2025-11-21T16:03:21Z

+    <item name = "ld_mask_tag" type="id"/>
+    <item name = "ld_unmask_tag" type="id"/>


This is the correct formatting when writing resources

Suggested change

<item name = "ld_mask_tag" type="id"/>

<item name = "ld_unmask_tag" type="id"/>

<item name="ld_mask_tag" type="id" />

<item name="ld_unmask_tag" type="id" />

Can I add local.properties into .gitignore? @agrognetti

agrognetti · 2025-11-21T17:44:48Z

+     */
+    private fun findNativeSensitiveRects(
+        view: View,
+        matchers: List<MaskMatcher>


This parameter is not used inside the function

agrognetti · 2025-11-21T17:53:38Z

+                null
+            }
+        } catch (ignored: Exception) {
+            null


Wouldn't be better to at least log the exceptions? Here and in the other "catch" blocks

* main: feat: Support ldMask() for Native and Compose views. (#295) chore: release main (#296) fix: tweaks Android InteractionDetector to delegate additional defaul… (#294)

🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-android: 0.15.0</summary> ## [0.15.0](launchdarkly-observability-android-0.14.1...launchdarkly-observability-android-0.15.0) (2025-11-21) ### Features * Support ldMask() for Native and Compose views. ([#295](#295)) ([6233764](6233764)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).  --- > [!NOTE] > Release observability-android 0.15.0 adding ldMask() support for Native and Compose views. > > - **Android SDK (`sdk/@launchdarkly/observability-android`)**: > - Version bump to `0.15.0` (`.release-please-manifest.json`, `gradle.properties`). > - Feature: add `ldMask()` support for Native and Compose views. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 430fcdb. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>

* main: (85 commits) doc: Add using ldMask in readme. (#311) chore: release main (#312) feat: take transformed coordinates, which are more precise in animation (#309) chore: release main (#307) fix(SEC-7530): update react-server-dom-webpack to 19.0.1 (#310) feat: recursive mask collection (#308) feat: support non-standard windows added by WindowManager (#306) feat: Android SR Do not send duplicate screens (#304) test: Add UI and logic to evaluate boolean flags (#305) chore: release main (#303) feat: Android Dialog Capture (#302) chore: Update Android Test main screen (#301) chore: release main (#300) feat: XML Views Automasking options (#299) fix: missed imports (#298) chore: release main (#297) feat: Support ldMask() for Native and Compose views. (#295) chore: release main (#296) fix: tweaks Android InteractionDetector to delegate additional defaul… (#294) chore: release main (#293) ... # Conflicts: # e2e/react-router/src/ldclientLazy.tsx # e2e/react-router/src/routes/root.tsx

abelonogov-ld added 7 commits November 17, 2025 21:41

Fruta xml

c7737c4

Rotate user address

1c35019

XML Credit Card Editor

4f6a6f9

ldMask for Compose and XML views

e7cab04

delete artifacts

7b48b46

Code clean up

1e78c1c

Some renaming

f9008c1

abelonogov-ld requested a review from a team as a code owner November 19, 2025 20:04

github-advanced-security AI found potential problems Nov 19, 2025

View reviewed changes

Comment thread e2e/android/app/src/main/res/layout/activity_credit_card.xml Dismissed

Comment thread e2e/android/app/src/main/res/layout/activity_smoothie_list.xml Dismissed

Comment thread e2e/android/app/src/main/res/layout/item_smoothie.xml Dismissed

cursor Bot reviewed Nov 19, 2025

View reviewed changes

Comment thread ...android/lib/src/main/kotlin/com/launchdarkly/observability/replay/SensitiveAreasCollector.kt

abelonogov-ld added 2 commits November 19, 2025 12:22

Small to check only ldMask flag

917929a

renaming file

89596e6

cursor Bot reviewed Nov 19, 2025

View reviewed changes

Comment thread ...android/lib/src/main/kotlin/com/launchdarkly/observability/replay/SensitiveAreasCollector.kt Outdated

abelonogov-ld added 2 commits November 19, 2025 15:15

missed

63d9734

fix child extending beyond parent view case

e162025

abelonogov-ld added 2 commits November 20, 2025 10:36

Merge branch 'main' into andrey/xml-views-ldmask

148e72c

Merge branch 'main' into andrey/xml-views-ldmask

f04c7eb

cursor Bot reviewed Nov 21, 2025

View reviewed changes

Comment thread ...android/lib/src/main/kotlin/com/launchdarkly/observability/replay/SensitiveAreasCollector.kt

Vadman97 approved these changes Nov 21, 2025

View reviewed changes

Comment thread ...android/lib/src/main/kotlin/com/launchdarkly/observability/replay/SensitiveAreasCollector.kt

abelonogov-ld enabled auto-merge (squash) November 21, 2025 18:10

abelonogov-ld merged commit 6233764 into main Nov 21, 2025
22 checks passed

abelonogov-ld deleted the andrey/xml-views-ldmask branch November 21, 2025 18:11

LaunchDarklyReleaseBot mentioned this pull request Nov 21, 2025

chore: release main #297

Merged

agrognetti suggested changes Nov 21, 2025

View reviewed changes

		<item name = "ld_mask_tag" type="id"/>
		<item name = "ld_unmask_tag" type="id"/>

Conversation

abelonogov-ld commented Nov 19, 2025 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How did you test this change?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tanderson-ld commented Nov 20, 2025

Uh oh!

Uh oh!

Vadman97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

agrognetti Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

agrognetti Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

agrognetti Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

agrognetti Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

abelonogov-ld Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

agrognetti Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

agrognetti Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

abelonogov-ld commented Nov 19, 2025 •

edited by cursor Bot

Loading