Skip to content

fix(store): align Store event names between IStoreWrite and StoreCore #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frolic merged 2 commits into from
Aug 3, 2023
Merged

fix(store): align Store event names between IStoreWrite and StoreCore #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1664e7f
fix(store): align Store events naming between IStoreWrite and StoreCore
alvrs Aug 3, 2023
e0d822a
add chagneset
alvrs Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-hats-walk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@latticexyz/store": patch
---

Align Store events parameter naming between IStoreWrite and StoreCore
6 changes: 3 additions & 3 deletions packages/store/abi/StoreCore.sol/StoreCore.abi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"indexed": false,
"internalType": "bytes32",
"name": "tableId",
"name": "table",
"type": "bytes32"
},
{
Expand Down Expand Up @@ -49,7 +49,7 @@
{
"indexed": false,
"internalType": "bytes32",
"name": "tableId",
"name": "table",
"type": "bytes32"
},
{
Expand Down Expand Up @@ -80,7 +80,7 @@
{
"indexed": false,
"internalType": "bytes32",
"name": "tableId",
"name": "table",
"type": "bytes32"
},
{
Expand Down
6 changes: 3 additions & 3 deletions packages/store/src/StoreCore.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ library StoreCore {
using TableId for bytes32;

// note: the preimage of the tuple of keys used to index is part of the event, so it can be used by indexers
event StoreSetRecord(bytes32 tableId, bytes32[] key, bytes data);
event StoreSetField(bytes32 tableId, bytes32[] key, uint8 schemaIndex, bytes data);
event StoreDeleteRecord(bytes32 tableId, bytes32[] key);
event StoreSetRecord(bytes32 table, bytes32[] key, bytes data);
event StoreSetField(bytes32 table, bytes32[] key, uint8 schemaIndex, bytes data);
event StoreDeleteRecord(bytes32 table, bytes32[] key);
event StoreEphemeralRecord(bytes32 table, bytes32[] key, bytes data);

/**
Expand Down
6 changes: 3 additions & 3 deletions packages/world/abi/StoreCore.sol/StoreCore.abi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"indexed": false,
"internalType": "bytes32",
"name": "tableId",
"name": "table",
"type": "bytes32"
},
{
Expand Down Expand Up @@ -49,7 +49,7 @@
{
"indexed": false,
"internalType": "bytes32",
"name": "tableId",
"name": "table",
"type": "bytes32"
},
{
Expand Down Expand Up @@ -80,7 +80,7 @@
{
"indexed": false,
"internalType": "bytes32",
"name": "tableId",
"name": "table",
"type": "bytes32"
},
{
Expand Down
6 changes: 3 additions & 3 deletions packages/world/abi/src/StoreCore.sol/StoreCore.abi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"indexed": false,
"internalType": "bytes32",
"name": "tableId",
"name": "table",
"type": "bytes32"
},
{
Expand Down Expand Up @@ -49,7 +49,7 @@
{
"indexed": false,
"internalType": "bytes32",
"name": "tableId",
"name": "table",
"type": "bytes32"
},
{
Expand Down Expand Up @@ -80,7 +80,7 @@
{
"indexed": false,
"internalType": "bytes32",
"name": "tableId",
"name": "table",
"type": "bytes32"
},
{
Expand Down