fix(store): align Store event names between IStoreWrite and StoreCore#1237
Merged
fix(store): align Store event names between IStoreWrite and StoreCore#1237
Conversation
🦋 Changeset detectedLatest commit: e0d822a The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
60608d5 to
e0d822a
Compare
frolic
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tableIdwhileIStoreWritehadtable, which created two entries in the generated ABI and caused aduplicate definitionwarningStoreCoreasIStoreWrite.StoreSetRecord, but this is only supported from Solidity version 0.8.21 (see Allow qualified access to events from other contracts argotorg/solidity#14274) and updating the Solidity version is a slightly bigger change than this quick fix