Skip to content

Conversation

@ccurme
Copy link
Contributor

@ccurme ccurme commented Sep 16, 2024

No description provided.

@ccurme
Copy link
Contributor Author

ccurme commented Sep 17, 2024

Integration tests may be failing for unrelated reasons. See this run on a recently merged PR that failed the same way.

@cbornet
Copy link
Collaborator

cbornet commented Sep 19, 2024

Integration tests may be failing for unrelated reasons

Yes integration tests have setup issues.

@cbornet
Copy link
Collaborator

cbornet commented Sep 19, 2024

I think we should follow LangChain baseline and drop support for the EOL'd Python 3.8.
cc @hemidactylus

@ccurme
Copy link
Contributor Author

ccurme commented Sep 19, 2024

Updated!

python = ">=3.9,<4.0"
langchain-core = ">=0.1.31,<0.4"
astrapy = "^1.4"
# Resolve numpy version for 3.8 to 3.12+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numpy resolution can probably be removed now to only use > 1.26

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call thanks.

@ccurme ccurme merged commit 1842e14 into main Sep 19, 2024
11 of 13 checks passed
@ccurme
Copy link
Contributor Author

ccurme commented Sep 19, 2024

Integration tests may be failing for unrelated reasons

Yes integration tests have setup issues.

@cbornet @hemidactylus the release pipeline appears blocked by failing integration tests. I suspect they are unrelated to this change and related to test infra. Would you mind taking a look?

@hemidactylus
Copy link
Collaborator

Integration tests may be failing for unrelated reasons

Yes integration tests have setup issues.

@cbornet @hemidactylus the release pipeline appears blocked by failing integration tests. I suspect they are unrelated to this change and related to test infra. Would you mind taking a look?

@ccurme Sure, the state of CI in this repo is on my TODOs for today. Thanks for reminding me :)

@cbornet cbornet deleted the update_deps_for_03 branch September 23, 2024 10:59
@hemidactylus
Copy link
Collaborator

@ccurme FYI #82 should pass all tests and get into main momentarily (if all goes well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants