Skip to content

fix(l1): sending ping to each neighbor found #5481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MegaRedHand merged 5 commits into from
Dec 2, 2025
Merged

fix(l1): sending ping to each neighbor found #5481

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4444685
Sending ping to each neighbor found
ElFantasma Dec 1, 2025
49369c7
Merge branch 'main' into bound_peers
ElFantasma Dec 1, 2025
2600477
Merge branch 'main' into bound_peers
ElFantasma Dec 1, 2025
c75d16b
Reverting ingore on error result
ElFantasma Dec 1, 2025
cbf7850
Merge branch 'main' into bound_peers
ElFantasma Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions crates/networking/p2p/discv4/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ impl DiscoveryServer {
// Sending all in one packet would exceed bounds with the nodes only, weighing
// up to 1424B.
for chunk in neighbors.chunks(8) {
let _ = self.send_neighbors(chunk.to_vec(), &contact.node).await;
self.send_neighbors(chunk.to_vec(), &contact.node).await?;
}
}
Ok(())
Expand All @@ -406,9 +406,13 @@ impl DiscoveryServer {
neighbors_message: NeighborsMessage,
) -> Result<(), DiscoveryServerError> {
// TODO(#3746): check that we requested neighbors from the node
let nodes = neighbors_message.nodes.clone();
self.peer_table
.new_contacts(neighbors_message.nodes, self.local_node.node_id())
.new_contacts(nodes, self.local_node.node_id())
.await?;
for node in neighbors_message.nodes {
self.send_ping(&node).await?;
}
Ok(())
}

Expand Down