Skip to content

fix(l1): sending ping to each neighbor found #5481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MegaRedHand merged 5 commits into from
Dec 2, 2025
Merged

fix(l1): sending ping to each neighbor found #5481

MegaRedHand merged 5 commits into from
Dec 2, 2025

Conversation

@ElFantasma
Copy link
Contributor

@ElFantasma ElFantasma commented Dec 1, 2025

Motivation
Our FindNode messages weren't responded as most of the remote nodes didn't know us.

Description

In order to be a known peer for the remote nodes we need to send a Ping message first. So, when we receive Neighbors from peers we send a Ping message to each one.

Closes #5480

@ElFantasma ElFantasma requested a review from a team as a code owner December 1, 2025 20:19
@github-actions github-actions bot added the L1 Ethereum client label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

Lines of code report

Total lines added: 4
Total lines removed: 0
Total lines changed: 4

Detailed view 
+-----------------------------------------------+-------+------+
| File                                          | Lines | Diff |
+-----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/discv4/server.rs | 499   | +4   |
+-----------------------------------------------+-------+------+

MegaRedHand
MegaRedHand reviewed Dec 1, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Dec 2, 2025
@MegaRedHand MegaRedHand added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 2c81438 Dec 2, 2025
45 checks passed
@MegaRedHand MegaRedHand deleted the bound_peers branch December 2, 2025 18:19
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablodeymo pablodeymo pablodeymo approved these changes

@fedacking fedacking fedacking approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees

@ElFantasma ElFantasma

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not initiating outbound connections except bootnodes.

5 participants

@ElFantasma @pablodeymo @fedacking @MegaRedHand