Skip to content

feat(l1,l2): make dev mode always use in memory db #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fedacking wants to merge 5 commits into from
Closed

feat(l1,l2): make dev mode always use in memory db #5359

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
624bba9
feat(l1,l2): make dev mode always use in memory db
fedacking Nov 14, 2025
996b0df
Merge remote-tracking branch 'origin/main' into dev-in-memory
fedacking Nov 14, 2025
c2da1dd
Parse datadir
fedacking Nov 14, 2025
26c3a2d
Update utils.rs
fedacking Nov 14, 2025
25c9644
Fixed l2 compiling
fedacking Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/ethrex/initializers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,11 @@ pub async fn init_l1(
opts: Options,
log_filter_handler: Option<reload::Handle<EnvFilter, Registry>>,
) -> eyre::Result<(PathBuf, CancellationToken, PeerTable, NodeRecord)> {
let datadir = &opts.datadir;
let datadir: &PathBuf = if opts.dev && cfg!(feature = "dev") {
Copy link
Collaborator

@mpaulucci mpaulucci Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of always, I would specify in memory by default. Also, I would set the default at the cli level, not here.

&Path::new("/tmp/memory").to_path_buf()
} else {
&opts.datadir
};
init_datadir(datadir);

let network = get_network(&opts);
Expand Down
Loading