Skip to content

Conversation

@fedacking
Copy link
Contributor

Motivation

We want the dev mode to use the in memory db for development work.

Description

  • Changed the init_l1 to use inmemory db if the dev option is on and the feature is enabled

@fedacking fedacking requested a review from a team as a code owner November 14, 2025 19:45
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Lines of code report

Total lines added: 21
Total lines removed: 0
Total lines changed: 21

Detailed view
+--------------------------------------+-------+------+
| File                                 | Lines | Diff |
+--------------------------------------+-------+------+
| ethrex/cmd/ethrex/cli.rs             | 768   | +8   |
+--------------------------------------+-------+------+
| ethrex/cmd/ethrex/l2/initializers.rs | 334   | +1   |
+--------------------------------------+-------+------+
| ethrex/cmd/ethrex/utils.rs           | 175   | +12  |
+--------------------------------------+-------+------+

log_filter_handler: Option<reload::Handle<EnvFilter, Registry>>,
) -> eyre::Result<(PathBuf, CancellationToken, PeerTable, NodeRecord)> {
let datadir = &opts.datadir;
let datadir: &PathBuf = if opts.dev && cfg!(feature = "dev") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of always, I would specify in memory by default. Also, I would set the default at the cli level, not here.

@fedacking
Copy link
Contributor Author

closed in favour of #5363

@fedacking fedacking closed this Nov 14, 2025
@MegaRedHand MegaRedHand deleted the dev-in-memory branch November 14, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client L2 Rollup client

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants