Skip to content

fix(l1,l2): make ethrex L1 + L2 + GPU build compile for ubuntu 22.04 #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilitteri merged 15 commits into from
Nov 11, 2025
Merged

fix(l1,l2): make ethrex L1 + L2 + GPU build compile for ubuntu 22.04 #5276

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9fbd782
ci(l1,l2): make release workflow "dry-run" on main
MegaRedHand Nov 11, 2025
7d45f5f
chore: run workflow for testing
MegaRedHand Nov 11, 2025
e1c950e
fix if condition
MegaRedHand Nov 11, 2025
304e54a
refactor: simplify how tag name is parsed
MegaRedHand Nov 11, 2025
ccffe06
fix: ref_name -> ref_type in if
MegaRedHand Nov 11, 2025
8cc5357
Revert "fix if condition"
MegaRedHand Nov 11, 2025
ecebab4
Revert "chore: run workflow for testing"
MegaRedHand Nov 11, 2025
26e94eb
Remove cpu_flags, this is not needed since we already have the `.carg…
Nov 11, 2025
2cc588b
Import `c-kzg` with its default features
Nov 11, 2025
50a3bdd
Merge branch 'release-workflow-smoke' of github.com:lambdaclass/ethre…
Nov 11, 2025
dee5f3b
Fix merge
Nov 11, 2025
27ea544
Trigger job in PR's CI
Nov 11, 2025
ba62f5c
Cleanup
Nov 11, 2025
92079b9
Remove main_docker_publish workflow
Nov 11, 2025
4cc5b80
Merge branch 'main' into fix_v7.0.0-rc.1
ilitteri Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/tag_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,14 @@ name: Ethrex Release

on:
push:
# On tags, this generates a release and pushes docker images with the tag name
tags:
- "v*.*.*-*"
# On pushes to main, this silently builds and pushes docker images tagged as 'main'
branches:
- main
# FIXME: This is to trigger the job in the PR's CI
- fix_v7.0.0-rc.1
Copy link
Collaborator

@MegaRedHand MegaRedHand Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a workflow_dispatch trigger, to make this run without adding patches like this

Copy link
Contributor Author

@ilitteri ilitteri Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good idea. We have something similar in ethrex-replay.

Copy link
Contributor Author

@ilitteri ilitteri Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that in another PR.


permissions:
contents: write
Expand Down Expand Up @@ -33,7 +39,6 @@ jobs:
- platform: ubuntu-22.04
os: linux
arch: x86_64
cpu_flags: RUSTFLAGS='-C target-cpu=x86-64-v2'
- platform: ubuntu-22.04-arm
os: linux
arch: aarch64
Expand Down Expand Up @@ -124,7 +129,7 @@ jobs:

- name: Build ethrex
run: |
COMPILE_CONTRACTS=true ${{ matrix.cpu_flags }} ${{ matrix.gpu_flags }} cargo build --release --features "${{ matrix.features }}" --bin ethrex
COMPILE_CONTRACTS=true ${{ matrix.gpu_flags }} cargo build --release --features "${{ matrix.features }}" --bin ethrex
chmod +x target/release/ethrex
mv target/release/ethrex ethrex${{ matrix.l2_suffix }}-${{ matrix.os }}-${{ matrix.arch }}${{ matrix.gpu_suffix }}

Expand Down Expand Up @@ -297,7 +302,13 @@ jobs:

- name: Format name
run: |
echo "TAG_VERSION=$(echo ${{ github.ref_name }} | tr -d v)" >> $GITHUB_ENV
# For branch builds (main) we want docker images tagged as 'main'. For tag pushes
Copy link
Contributor

@ManuelBilbao ManuelBilbao Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a CI that builds the docker image for main commits. We should remove either that or this

Copy link
Contributor Author

@ilitteri ilitteri Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change replace entirely the tag_latest workflow?

Copy link
Contributor Author

@ilitteri ilitteri Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

92079b9

# use the tag name (stripped of a leading 'v').
if [[ "$GITHUB_REF" == "refs/heads/main" ]]; then
Copy link
Collaborator

@MegaRedHand MegaRedHand Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion from copilot:

Suggested change
if [[ "$GITHUB_REF" == "refs/heads/main" ]]; then
if [[ ${{ github.ref_type }} == "branch" ]]; then

echo "TAG_VERSION=main" >> $GITHUB_ENV
else
echo "TAG_VERSION=$(echo ${{ github.ref_name }} | tr -d v)" >> $GITHUB_ENV
fi

# Pushes to ghcr.io/lambdaclass/ethrex
- name: Build and push L1 Docker image
Expand All @@ -324,6 +335,7 @@ jobs:

# Creates a release on GitHub with the binaries
finalize-release:
if: github.ref_type == 'tag'
needs:
- build-ethrex
- build-ethrex-guest
Expand Down
5 changes: 1 addition & 4 deletions crates/common/crypto/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ path = "./lib.rs"

[dependencies]
# TODO(#1102): Move to Lambdaworks in the future
c-kzg = { version = "2.1.1", default-features = false, optional = true, features = [
"ethereum_kzg_settings",
"std",
] }
c-kzg = { version = "2.1.1", optional = true }
kzg-rs.workspace = true

thiserror.workspace = true
Expand Down
Loading