-
Notifications
You must be signed in to change notification settings - Fork 132
fix(l1,l2): make ethrex L1 + L2 + GPU build compile for ubuntu 22.04 #5276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9fbd782
ci(l1,l2): make release workflow "dry-run" on main
MegaRedHand 7d45f5f
chore: run workflow for testing
MegaRedHand e1c950e
fix if condition
MegaRedHand 304e54a
refactor: simplify how tag name is parsed
MegaRedHand ccffe06
fix: ref_name -> ref_type in if
MegaRedHand 8cc5357
Revert "fix if condition"
MegaRedHand ecebab4
Revert "chore: run workflow for testing"
MegaRedHand 26e94eb
Remove cpu_flags, this is not needed since we already have the `.carg…
2cc588b
Import `c-kzg` with its default features
50a3bdd
Merge branch 'release-workflow-smoke' of github.com:lambdaclass/ethre…
dee5f3b
Fix merge
27ea544
Trigger job in PR's CI
ba62f5c
Cleanup
92079b9
Remove main_docker_publish workflow
4cc5b80
Merge branch 'main' into fix_v7.0.0-rc.1
ilitteri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,8 +2,12 @@ name: Ethrex Release | |||||
|
|
||||||
| on: | ||||||
| push: | ||||||
| # On tags, this generates a release and pushes docker images with the tag name | ||||||
| tags: | ||||||
| - "v*.*.*-*" | ||||||
| # On pushes to main, this silently builds and pushes docker images tagged as 'main' | ||||||
| branches: | ||||||
| - main | ||||||
|
|
||||||
| permissions: | ||||||
| contents: write | ||||||
|
|
@@ -33,7 +37,6 @@ jobs: | |||||
| - platform: ubuntu-22.04 | ||||||
| os: linux | ||||||
| arch: x86_64 | ||||||
| cpu_flags: RUSTFLAGS='-C target-cpu=x86-64-v2' | ||||||
| - platform: ubuntu-22.04-arm | ||||||
| os: linux | ||||||
| arch: aarch64 | ||||||
|
|
@@ -124,7 +127,7 @@ jobs: | |||||
|
|
||||||
| - name: Build ethrex | ||||||
| run: | | ||||||
| COMPILE_CONTRACTS=true ${{ matrix.cpu_flags }} ${{ matrix.gpu_flags }} cargo build --release --features "${{ matrix.features }}" --bin ethrex | ||||||
| COMPILE_CONTRACTS=true ${{ matrix.gpu_flags }} cargo build --release --features "${{ matrix.features }}" --bin ethrex | ||||||
| chmod +x target/release/ethrex | ||||||
| mv target/release/ethrex ethrex${{ matrix.l2_suffix }}-${{ matrix.os }}-${{ matrix.arch }}${{ matrix.gpu_suffix }} | ||||||
|
|
||||||
|
|
@@ -297,7 +300,13 @@ jobs: | |||||
|
|
||||||
| - name: Format name | ||||||
| run: | | ||||||
| echo "TAG_VERSION=$(echo ${{ github.ref_name }} | tr -d v)" >> $GITHUB_ENV | ||||||
| # For branch builds (main) we want docker images tagged as 'main'. For tag pushes | ||||||
| # use the tag name (stripped of a leading 'v'). | ||||||
| if [[ "$GITHUB_REF" == "refs/heads/main" ]]; then | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion from copilot:
Suggested change
|
||||||
| echo "TAG_VERSION=main" >> $GITHUB_ENV | ||||||
| else | ||||||
| echo "TAG_VERSION=$(echo ${{ github.ref_name }} | tr -d v)" >> $GITHUB_ENV | ||||||
| fi | ||||||
|
|
||||||
| # Pushes to ghcr.io/lambdaclass/ethrex | ||||||
| - name: Build and push L1 Docker image | ||||||
|
|
@@ -324,6 +333,7 @@ jobs: | |||||
|
|
||||||
| # Creates a release on GitHub with the binaries | ||||||
| finalize-release: | ||||||
| if: github.ref_type == 'tag' | ||||||
| needs: | ||||||
| - build-ethrex | ||||||
| - build-ethrex-guest | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's already a CI that builds the docker image for main commits. We should remove either that or this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change replace entirely the
tag_latestworkflow?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
92079b9