Skip to content

Conversation

@iovoid
Copy link
Contributor

@iovoid iovoid commented Nov 6, 2025

Motivation

We see decompression taking a significant part of database reads.

Description

Here we disable compression for the table where FKVs are stored, and use a hash-based index optimized for point operations.

@github-actions github-actions bot added L1 Ethereum client performance Block execution throughput and performance in general labels Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Lines of code report

Total lines added: 9
Total lines removed: 0
Total lines changed: 9

Detailed view
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/rocksdb.rs | 1604  | +9   |
+-------------------------------------------+-------+------+

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Benchmark Block Execution Results Comparison Against Main

Command Mean [s] Min [s] Max [s] Relative
base 61.374 ± 0.239 61.122 61.812 1.00
head 61.458 ± 0.341 60.943 61.894 1.00 ± 0.01

@iovoid iovoid force-pushed the fkv_no_compression branch from b20370a to 278dfdd Compare November 7, 2025 20:07
@jrchatruc jrchatruc marked this pull request as ready for review November 10, 2025 22:29
@jrchatruc jrchatruc requested a review from a team as a code owner November 10, 2025 22:29
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Nov 10, 2025
@iovoid iovoid changed the title perf(l1): disable compression and optimized fkv indexing for point lookup perf(l1): disable compression of database Nov 11, 2025
@jrchatruc jrchatruc added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit 4e239ae Nov 11, 2025
47 checks passed
@jrchatruc jrchatruc deleted the fkv_no_compression branch November 11, 2025 15:36
@github-project-automation github-project-automation bot moved this from Todo to Done in ethrex_performance Nov 11, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Nov 11, 2025
xqft pushed a commit that referenced this pull request Nov 11, 2025
**Motivation**

We see decompression taking a significant part of database reads.

**Description**

Here we disable compression for the table where FKVs are stored, and use
a hash-based index optimized for point operations.

---------

Co-authored-by: Javier Rodríguez Chatruc <[email protected]>
Co-authored-by: Javier Chatruc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client performance Block execution throughput and performance in general

Projects

Status: Done
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants