perf(l1)!: separate Account and storage Column families #5055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Arkenan
changed the title
Arkenan
changed the title
MegaRedHand
reviewed
Nov 11, 2025
Comment on lines
+557
to
+558
| // TODO(#5195): committing each storage trie individually is inefficient. | ||
| // We would benefit form a mass storage node insertion method. |
Collaborator
There was a problem hiding this comment.
Can't we do it like before, with Trie::collect_changes_since_last_hash()? We can store the changes inside a shared buffer, and dump it in the DB at the end.
Contributor
There was a problem hiding this comment.
I agree, we already have commit_without_storing for that.
That said, the genesis runs exactly once and I think it's quick enough as it is.
iovoid
reviewed
Nov 11, 2025
MegaRedHand
changed the title
MegaRedHand
approved these changes
Nov 12, 2025
Oppen
approved these changes
Nov 12, 2025
github-project-automation
bot
moved this from In Progress
to Done
in ethrex_performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to separate both the trie nodes and flat key value representation for accounts and storage, as they can be updated separately.