fix(l1): fix breakdown pie chart #5202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates a Grafana dashboard configuration for Ethrex L1 performance monitoring. The change refines the metrics query to provide better visibility into the block execution pipeline by excluding additional function names and adding a new calculated metric.
- Modified the Prometheus query to exclude "Execute Block", "Trie update", and "Block DB update" from the main aggregation
- Added a new label_replace calculation to track "Other (Pipeline Diff)" metric
- Incremented dashboard version from 29 to 30
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MegaRedHand
approved these changes
Nov 5, 2025
pablodeymo
approved these changes
Nov 6, 2025
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
**Motivation** The `Execution Breakdown` pie chart was broken after #5084 **Description** This PR is a quick fix of the pie chart, the idea is to have a complete rework in a follow-up PR but for now it serves to avoid showing misleading info, now the chart effectively measures `execute_block_pipeline` + the sync store step after it: - Now that Block Execution and Merkleization are part of `execute_block_pipeline` we removed the Trie update measure (merkleization) from the chart because it will be happening concurrently with execution. - We added a new `Other (pipeline diff)` measure, that takes the whole `execute_block_pipeline` and removes the execution from it (aka the missing merkleization measure). | Main | This PR | | ---- | ---- | | <img width="741" height="427" alt="image" src="https://github.com/user-attachments/assets/3025cd92-6355-4365-92de-f9eb4039d97e" /> | <img width="744" height="465" alt="image" src="https://github.com/user-attachments/assets/7e2f7784-0666-4984-aef8-cd39e10f6ca7" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
Execution Breakdownpie chart was broken after #5084Description
This PR is a quick fix of the pie chart, the idea is to have a complete rework in a follow-up PR but for now it serves to avoid showing misleading info, now the chart effectively measures
execute_block_pipeline+ the sync store step after it:execute_block_pipelinewe removed the Trie update measure (merkleization) from the chart because it will be happening concurrently with execution.Other (pipeline diff)measure, that takes the wholeexecute_block_pipelineand removes the execution from it (aka the missing merkleization measure).