Skip to content

Commit 566964c

Browse files
rodrigo-oxqft
authored andcommitted
fix(l1): fix breakdown pie chart (#5202)
**Motivation** The `Execution Breakdown` pie chart was broken after #5084 **Description** This PR is a quick fix of the pie chart, the idea is to have a complete rework in a follow-up PR but for now it serves to avoid showing misleading info, now the chart effectively measures `execute_block_pipeline` + the sync store step after it: - Now that Block Execution and Merkleization are part of `execute_block_pipeline` we removed the Trie update measure (merkleization) from the chart because it will be happening concurrently with execution. - We added a new `Other (pipeline diff)` measure, that takes the whole `execute_block_pipeline` and removes the execution from it (aka the missing merkleization measure). | Main | This PR | | ---- | ---- | | <img width="741" height="427" alt="image" src="https://github.com/user-attachments/assets/3025cd92-6355-4365-92de-f9eb4039d97e" /> | <img width="744" height="465" alt="image" src="https://github.com/user-attachments/assets/7e2f7784-0666-4984-aef8-cd39e10f6ca7" /> |
1 parent cbb349e commit 566964c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

metrics/provisioning/grafana/dashboards/common_dashboards/ethrex_l1_perf.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,7 +1249,7 @@
12491249
{
12501250
"disableTextWrap": false,
12511251
"editorMode": "code",
1252-
"expr": "(\n sum by (function_name) (\n increase(function_duration_seconds_sum{job=\"$job\", instance=~\"$instance(:\\\\d+)?$\", function_name!=\"Block execution\"}[$__range])\n )\n)\nor\nlabel_replace(\n sum( increase(function_duration_seconds_sum{job=\"$job\", instance=~\"$instance(:\\\\d+)?$\", function_name=\"Block execution\"}[$__range]) )\n - sum( increase(function_duration_seconds_sum{job=\"$job\", instance=~\"$instance(:\\\\d+)?$\", function_name=~\"Storage read|Account read|Account Read\"}[$__range]) ),\n \"function_name\",\"Block execution (without db)\",\"__name__\",\".*\"\n)",
1252+
"expr": "(\n sum by (function_name) (\n increase(function_duration_seconds_sum{job=\"$job\", instance=~\"$instance(:\\\\d+)?$\", function_name!~\"Block execution|Execute Block|Trie update\"}[$__range])\n )\n)\nor\nlabel_replace(\n sum( increase(function_duration_seconds_sum{job=\"$job\", instance=~\"$instance(:\\\\d+)?$\", function_name=\"Block execution\"}[$__range]) )\n - sum( increase(function_duration_seconds_sum{job=\"$job\", instance=~\"$instance(:\\\\d+)?$\", function_name=~\"Storage read|Account read|Account Read\"}[$__range]) ),\n \"function_name\",\"Block execution (without db)\",\"__name__\",\".*\"\n)\nor\nlabel_replace(\n sum( increase(function_duration_seconds_sum{job=\"$job\", instance=~\"$instance(:\\\\d+)?$\", function_name=\"Execute Block\"}[$__range]) )\n - sum( increase(function_duration_seconds_sum{job=\"$job\", instance=~\"$instance(:\\\\d+)?$\", function_name=\"Block execution\"}[$__range]) ),\n \"function_name\",\"Other (Pipeline Diff)\",\"__name__\",\".*\"\n)",
12531253
"fullMetaSearch": false,
12541254
"includeNullMetadata": false,
12551255
"legendFormat": "__auto",
@@ -2569,5 +2569,5 @@
25692569
"timezone": "utc",
25702570
"title": "Ethrex L1 - Perf Dashboard",
25712571
"uid": "beoru4vp59yiof",
2572-
"version": 29
2572+
"version": 30
25732573
}

0 commit comments

Comments
 (0)