Skip to content

feat(l2): reject privileged transactions in p2p messages #5086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomip01 merged 6 commits into from
Oct 29, 2025
Merged

feat(l2): reject privileged transactions in p2p messages #5086

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4a1ec66
reject privileged txs in p2p messages
tomip01 Oct 28, 2025
5d49530
add reject for NewPooledTransactionHashes
tomip01 Oct 28, 2025
b1560b6
simpify if
tomip01 Oct 28, 2025
f27c444
filter maps before chunking
tomip01 Oct 28, 2025
02308eb
remove priv tx from p2p enum
tomip01 Oct 28, 2025
63675e2
add comment to say we exclude priv tx from p2p txs
tomip01 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions crates/networking/p2p/rlpx/connection/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,8 +933,12 @@ async fn handle_incoming_message(
for tx in &txs.transactions {
// Reject blob transactions in L2 mode
#[cfg(feature = "l2")]
if is_l2_mode && matches!(tx, Transaction::EIP4844Transaction(_)) {
debug!(peer=%state.node, "Rejecting blob transaction in L2 mode - blob transactions are not supported in L2");
if is_l2_mode
&& (matches!(tx, Transaction::EIP4844Transaction(_))
|| matches!(tx, Transaction::PrivilegedL2Transaction(_)))
{
let tx_type = tx.tx_type();
debug!(peer=%state.node, "Rejecting transaction in L2 mode - {tx_type} transactions are not broadcasted in L2");
continue;
}

Expand Down
7 changes: 7 additions & 0 deletions crates/networking/p2p/rlpx/eth/transactions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,13 @@ impl PooledTransactions {
continue;
}
} else {
if matches!(tx, P2PTransaction::PrivilegedL2Transaction(_)) && is_l2_mode {
debug!(
peer=%node,
"Rejecting privileged L2 transaction in L2 mode - privileged L2 transactions are not broadcasted",
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message is inconsistent with the one in server.rs (line 941). Consider using a similar pattern by extracting the transaction type to make messages consistent: let tx_type = tx.tx_type(); debug!(peer=%node, \"Rejecting transaction in L2 mode - {tx_type} transactions are not broadcasted in L2\");

Suggested change
debug!(
peer=%node,
"Rejecting privileged L2 transaction in L2 mode - privileged L2 transactions are not broadcasted",
let tx_type = tx.tx_type();
debug!(
peer=%node,
"Rejecting transaction in L2 mode - {tx_type} transactions are not broadcasted in L2",

Copilot uses AI. Check for mistakes.
);
continue;
}
let regular_tx = tx
.try_into()
.map_err(|error| MempoolError::StoreError(StoreError::Custom(error)))?;
Expand Down
Loading