feat(l2): reject privileged transactions in p2p messages

[tomip01]

Motivation

We don't want to broadcast Privileged transactions between peers as every lead sequencer can get them through the OnChainProposer contract and look for the logs.

Description

The P2P messages that broadcast transactions are:

• Transactions
  • Added a new matches!(..) to deny them
• NewPooledTransactionHashes
  • Add a new check for sending tx hashes to not be a privileged one
• GetPooledTransactions
  • Are currently rejected inside the function get_p2p_transaction_by_hash
• PooledTransactions: the response form the GetPooledTransactions
  • Added a new matches!(..) inside the handle method to reject adding them to the mempool

[Copilot]

Pull Request Overview

This PR adds rejection logic for privileged L2 transactions when operating in L2 mode, preventing these transactions from being broadcasted through the peer-to-peer network.

• Added validation to reject privileged L2 transactions in L2 mode alongside existing blob transaction rejections
• Updated debug messages to provide clearer information about rejected transaction types

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/networking/p2p/rlpx/eth/transactions.rs	Added check to reject privileged L2 transactions in pooled transactions handler
crates/networking/p2p/rlpx/connection/server.rs	Expanded transaction rejection logic to include privileged L2 transactions and improved debug message formatting

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The error message is inconsistent with the one in server.rs (line 941). Consider using a similar pattern by extracting the transaction type to make messages consistent: let tx_type = tx.tx_type(); debug!(peer=%node, \"Rejecting transaction in L2 mode - {tx_type} transactions are not broadcasted in L2\");

Suggested change

	debug!(
	peer=%node,
	"Rejecting privileged L2 transaction in L2 mode - privileged L2 transactions are not broadcasted",
	let tx_type = tx.tx_type();
	debug!(
	peer=%node,
	"Rejecting transaction in L2 mode - {tx_type} transactions are not broadcasted in L2",

[github-actions]

Lines of code report

Total lines added: 7
Total lines removed: 11
Total lines changed: 18

Detailed view

+--------------------------------------------------------+-------+------+
| File                                                   | Lines | Diff |
+--------------------------------------------------------+-------+------+
| ethrex/crates/common/types/transaction.rs              | 2837  | -11  |
+--------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/server.rs | 1022  | +4   |
+--------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/tx_broadcaster.rs         | 309   | +3   |
+--------------------------------------------------------+-------+------+

[MegaRedHand]

We should probably document this change somewhere.

[tomip01]

Done 63675e2