Skip to content

Allow creating secrets for the not yet existing mesh #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakubdyszkiewicz merged 1 commit into from
Nov 5, 2021
Merged

Allow creating secrets for the not yet existing mesh #3076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/plugins/runtime/k8s/webhooks/secret_validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,7 @@ func (v *SecretValidator) validateMeshSecret(ctx context.Context, verr *validato
Name: meshOfSecret(secret),
}
if err := v.Client.Get(ctx, key, &mesh); err != nil {
if kube_apierrs.IsNotFound(err) {
verr.AddViolationAt(validators.RootedAt("metadata").Field("labels").Key(meshLabel), "mesh does not exist")
} else {
if !kube_apierrs.IsNotFound(err) {
return errors.Wrap(err, "could not fetch mesh")
}
}
Expand Down
22 changes: 6 additions & 16 deletions pkg/plugins/runtime/k8s/webhooks/secret_validator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ var _ = Describe("ServiceValidator", func() {
uid: ""
`,
}),
Entry("should not allow Secret with mesh that does not exist", testCase{
Entry("should allow Secret with mesh that does not exist", testCase{
request: `
apiVersion: admission.k8s.io/v1
kind: AdmissionReview
Expand All @@ -202,21 +202,11 @@ var _ = Describe("ServiceValidator", func() {
operation: CREATE
`,
expected: `
allowed: false
status:
code: 422
details:
causes:
- field: metadata.labels["kuma.io/mesh"]
message: mesh does not exist
reason: FieldValueInvalid
kind: Secret
name: sec-1
message: 'metadata.labels["kuma.io/mesh"]: mesh does not exist'
metadata: {}
reason: Invalid
status: Failure
uid: ""
allowed: true
status:
code: 200
metadata: {}
uid: ""
`,
}),
Entry("should not allow switching mesh in Secret", testCase{
Expand Down