Allow creating secrets for the not yet existing mesh #3076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cloudwiz <[email protected]>
andrey-dubnik
force-pushed
the
dev-secret-no-mesh-validate
branch
from
0573eb5 to
458aacb
Compare
jakubdyszkiewicz
approved these changes
Nov 3, 2021
Contributor
jakubdyszkiewicz
left a comment
jakubdyszkiewicz
left a comment
There was a problem hiding this comment.
make sense for me
Contributor
|
I also checked Universal and we don't have such validation there |
lahabana
approved these changes
Nov 3, 2021
Contributor
|
Should we consider backporting this as well? |
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2021
…3076) Signed-off-by: cloudwiz <[email protected]> (cherry picked from commit dea27fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow creating secrets for the mesh which does not exists. This will unblock the flow where mesh have to be created with the mTLS turned on as otherwise secrets can't be created before the mesh exists.
Full changelog
Issues resolved
Fix #2722
Documentation
Testing
Backwards compatibility