build: update to use PUSH_TARGETS to generate list of images for hack/push-container-manifest.sh#3998
Merged
Conversation
kubevirt-bot
added
release-note-none
Acedus
force-pushed
the
bazel-push-images-use-skopeo
branch
3 times, most recently
from
0a2dabc to
2415163
Compare
…ontainer-manifest.sh Signed-off-by: Adi Aloni <[email protected]>
Signed-off-by: Adi Aloni <[email protected]>
Acedus
force-pushed
the
bazel-push-images-use-skopeo
branch
from
2415163 to
06e6460
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Contributor
Author
|
/test pull-containerized-data-importer-fossa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rather than dynamically finding the images names in hack/bazel-push-images.sh - use the list of
PUSH_TARGETSthat is already present. This fixes an issue where the digests would be missing after finishing the push since the transition fromrules_dockertorules_ociasrules_ocidoesn't create a digest file after pushing the image.Also add a check to see if the remote image exists before adding it to the multiarch manifest.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Depends on #3997.
xref: kubevirt/kubevirt#15741, kubevirt/kubevirt#15793
Release note: