Skip to content

bazel-builder: add skopeo#3997

Merged
kubevirt-bot merged 1 commit into
kubevirt:mainfrom
Acedus:bazel-builder-skopeo
Dec 25, 2025
Merged

bazel-builder: add skopeo#3997
kubevirt-bot merged 1 commit into
kubevirt:mainfrom
Acedus:bazel-builder-skopeo

Conversation

@Acedus
Copy link
Copy Markdown
Contributor

@Acedus Acedus commented Dec 25, 2025

Skopeo is required to generate the list of images for hack/push-container-manifest.sh as it will be used to ensure the target images exist.

What this PR does / why we need it:
This PR adds Skopeo to the bazel-builder image in order to use it instead of relying on the image digests when creating the image manifest in hack/push-container-manifest.sh.

Skopeo is required to generate the list of images for hack/push-container-manifest.sh as it will be used to ensure the target images exist.

Relevant scripts will be updated to utilize Skopeo in following PRs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
Reasoning for this change: kubevirt/kubevirt#15793

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 25, 2025
@Acedus
Copy link
Copy Markdown
Contributor Author

Acedus commented Dec 25, 2025

/cc @akalenyu

Comment thread hack/build/docker/builder/Dockerfile Outdated
@Acedus Acedus force-pushed the bazel-builder-skopeo branch from da64739 to 9a95e71 Compare December 25, 2025 12:53
Skopeo is required to generate the list of images for
hack/push-container-manifest.sh as it will be used to ensure the target
images exist.

Signed-off-by: Adi Aloni <[email protected]>
@Acedus Acedus force-pushed the bazel-builder-skopeo branch from 9a95e71 to 1a84135 Compare December 25, 2025 12:54
Copy link
Copy Markdown
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 25, 2025
@kubevirt-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2025
@Acedus
Copy link
Copy Markdown
Contributor Author

Acedus commented Dec 25, 2025

/test pull-containerized-data-importer-e2e-ceph

@akalenyu
Copy link
Copy Markdown
Collaborator

/retest
unrelated

@kubevirt-bot kubevirt-bot merged commit a38f16d into kubevirt:main Dec 25, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants