bazel-builder: add skopeo#3997
Merged
Merged
Conversation
Contributor
Author
|
/cc @akalenyu |
akalenyu
reviewed
Dec 25, 2025
da64739 to
9a95e71
Compare
Skopeo is required to generate the list of images for hack/push-container-manifest.sh as it will be used to ensure the target images exist. Signed-off-by: Adi Aloni <[email protected]>
9a95e71 to
1a84135
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/test pull-containerized-data-importer-e2e-ceph |
Collaborator
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skopeo is required to generate the list of images for hack/push-container-manifest.sh as it will be used to ensure the target images exist.
What this PR does / why we need it:
This PR adds Skopeo to the bazel-builder image in order to use it instead of relying on the image digests when creating the image manifest in
hack/push-container-manifest.sh.Skopeo is required to generate the list of images for hack/push-container-manifest.sh as it will be used to ensure the target images exist.
Relevant scripts will be updated to utilize Skopeo in following PRs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Reasoning for this change: kubevirt/kubevirt#15793
Release note: