Skip to content

Graduate elastic indexed job to stable #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Jun 13, 2024
Merged

Graduate elastic indexed job to stable #4718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions keps/prod-readiness/sig-apps/3715.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
kep-number: 3715
beta:
approver: "@wojtek-t"
stable:
approver: "@wojtek-t"

10 changes: 7 additions & 3 deletions keps/sig-apps/3715-elastic-indexed-job/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,9 @@ enhancement:

### Version Skew Strategy

N/A. This feature doesn't impact nodes.
In a multi-master setup, when the cluster has skewed apiservers, some create requests
may get accepted and some may get rejected. This is a transient state until all instances are on the same k8s version.


<!--
If applicable, how will the component handle version skew with other
Expand Down Expand Up @@ -595,7 +597,8 @@ The api-server will accept mutation requests to `spec.completions` for `Indexed`

###### Are there any tests for feature enablement/disablement?

N/A
See [Job integration tests](https://github.com/kubernetes/kubernetes/blob/a06568062c41b4f0f903dcb78aa6ea348bbdecfc/test/integration/job/job_test.go#L2746)


<!--
The e2e framework does not currently support enabling or disabling feature
Expand Down Expand Up @@ -641,7 +644,7 @@ that might indicate a serious problem?

###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
Copy link
Contributor

@soltysh soltysh Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several minor nits:

Copy link
Member Author

@ahg-g ahg-g Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done


It will be tested manually prior to beta launch.
It was tested manually prior to beta launch, but also given the feature effectively is only relaxing validation (so is purely in-memory), upgrade/downgrade boils down to actual feature tests.

<!--
Describe manual testing that was done and the outcomes.
Expand Down Expand Up @@ -893,6 +896,7 @@ N/A.

## Implementation History

- 2024-06-12: Graduated to stable.
- 2023-01-10: Proposed KEP.

<!--
Expand Down
6 changes: 3 additions & 3 deletions keps/sig-apps/3715-elastic-indexed-job/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ see-also:
- "/keps/sig-apps/2214-indexed-job"

# The target maturity stage in the current dev cycle for this KEP.
stage: beta
stage: stable

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.27"
latest-milestone: "v1.31"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
beta: "1.27"
stable: "v1.28"
stable: "v1.31"

feature-gates:
- name: ElasticIndexedJob
Expand Down