-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Graduate elastic indexed job to stable #4718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ahg-g
commented
Jun 12, 2024
- One-line PR description: graduate to stable
- Issue link: Elastic Indexed Jobs #3715
- Other comments:
| beta: | ||
| approver: "@wojtek-t" | ||
| stable: | ||
| approver: "@soltysh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please switch back to me - we're generally not changing approvers in the middle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW - the only comment I have about PRR is the upgrade->downgrade->upgrade tests.
Please update it.
[I'm fine with saying that given the feature effectively is only relaxing validation (so is purely in-memory), upgrade/downgrade boils down to actual feature tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg, done.
|
/assign @soltysh |
|
/approve PRR |
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several minor nits.
/approve
from sig-apps pov
| that might indicate a serious problem? | ||
| --> | ||
|
|
||
| ###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several minor nits:
- in
### Version Skew Strategyyou could copy the same answer as you have in###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?section or###### What are other known failure modes?(linking to them is also fine). - in
###### Are there any tests for feature enablement/disablement?you have N/A, but you could actually link to https://github.com/kubernetes/kubernetes/blob/a06568062c41b4f0f903dcb78aa6ea348bbdecfc/test/integration/job/job_test.go#L2746 - please update
## Implementation History
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, done
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, soltysh, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |