-
Notifications
You must be signed in to change notification settings - Fork 246
Update k8s client libs to v0.32.2 #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @theobarberbany! |
|
Hi @theobarberbany. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Ah - Will work through https://github.com/kubernetes/cloud-provider-gcp/blob/master/docs/instruction-how-to-bump-repository.md and update. |
|
Hello @theobarberbany, thank you for the PR! could you also extend this with points 1-3 from here https://github.com/kubernetes/cloud-provider-gcp/blob/master/docs/instruction-how-to-bump-repository.md? specifically the version in ginko-test-package-version.env don't do the cluster/ directory sync, we can follow up with that later |
e8d8348 to
8fe9168
Compare
|
Heya @mmamczur. I've updated the PR with changes for points 1-3. |
6f18945 to
f6567d5
Compare
|
/ok-to-test |
|
/retest |
f6567d5 to
f4ff675
Compare
|
Hmm, looks like the cloud controller manager is failing to come up on the master. Logs kubelet on node: I'm not sure where this RBAC change may have come from, will look at changelogs. |
|
/test cloud-provider-gcp-e2e-full |
|
Also found this error in the kube-controller-manager logs: And we're setting: It looks like it was removed in this PR kubernetes/kubernetes#128197 (cc @aojea) and some similar config change may hae been required? |
|
@mmamczur should we do a branch cut before merging this PR? Otherwise 1.31 will be missing and directly goes to 1.32 |
I created it already https://github.com/kubernetes/cloud-provider-gcp/tree/release-1.31 Iteresting, I see that now the e2e-full passed, let's retrigger since kops failure looks like a flake /retest |
|
actually, we should try updating that cluster/ dir first, I think it has the change you mentioned |
|
For #803, it looks like it's mostly passing? Just a single failure. Is the approach of disabling KUBE_GCE_ENABLE_IP_ALIASES not the right way forward here? |
|
ok, it passed now. @theobarberbany if you'd like to use your PR then could you cherrypick (or you could probably just fast forward since it is based on your commits) this commit 14c5bdc on your changes? (and remove the one that does test disabling KUBE_GCE_ENABLE_IP_ALIASES) it's best if we don't touch that config variable the thing with this |
0527303 to
7582c5a
Compare
|
Ok great, I've updated :) Also that is very annoying, but good to know! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmamczur, theobarberbany The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.