Skip to content

Conversation

@mmamczur
Copy link
Contributor

This does not include changes to cluster since there were no differences for it in kubernetes/kubernetes between 1.31.2 and 1.31.5.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 12, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@mmamczur
Copy link
Contributor Author

/assign @aojea

the idea is to merge this so that we have recent 1.31, create a release branch and update to 1.32 as well

go.mod Outdated
Comment on lines 16 to 19
k8s.io/api v0.32.1
k8s.io/apimachinery v0.32.1
k8s.io/apiserver v0.31.5
k8s.io/client-go v0.32.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is recommended to use the same version, this should be 0.31.5 too

go.mod Outdated
Comment on lines 16 to 19
k8s.io/api v0.32.1
k8s.io/apimachinery v0.32.1
k8s.io/apiserver v0.31.5
k8s.io/client-go v0.32.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
k8s.io/api v0.32.1
k8s.io/apimachinery v0.32.1
k8s.io/apiserver v0.31.5
k8s.io/client-go v0.32.1
k8s.io/api v0.31.5
k8s.io/apimachinery v0.31.5
k8s.io/apiserver v0.31.5
k8s.io/client-go v0.31.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no no, I don't know how this happened, some dep must have updated these

all I did was go get -u k8s.io/[email protected] on the k8s.io packages. Not sure how it forced 0.32 for some of them

in any case, I updated the PR

@theobarberbany
Copy link
Contributor

/lgtm
/hold

I think this looks good!

If any extra hands are needed, I'm happy to help on the 1.32 bump.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
@k8s-ci-robot
Copy link
Contributor

@theobarberbany: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/hold

I think this looks good!

If any extra hands are needed, I'm happy to help on the 1.32 bump.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aojea
Copy link
Member

aojea commented Feb 17, 2025

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 54cd0bb into kubernetes:master Feb 17, 2025
7 checks passed
@theobarberbany
Copy link
Contributor

I've raised #802

./tools/verify-all.sh passes locally, so should be good to test I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants