-
Notifications
You must be signed in to change notification settings - Fork 246
Update k8s client libs to v0.31.5. #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmamczur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @aojea the idea is to merge this so that we have recent 1.31, create a release branch and update to 1.32 as well |
go.mod
Outdated
| k8s.io/api v0.32.1 | ||
| k8s.io/apimachinery v0.32.1 | ||
| k8s.io/apiserver v0.31.5 | ||
| k8s.io/client-go v0.32.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is recommended to use the same version, this should be 0.31.5 too
go.mod
Outdated
| k8s.io/api v0.32.1 | ||
| k8s.io/apimachinery v0.32.1 | ||
| k8s.io/apiserver v0.31.5 | ||
| k8s.io/client-go v0.32.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| k8s.io/api v0.32.1 | |
| k8s.io/apimachinery v0.32.1 | |
| k8s.io/apiserver v0.31.5 | |
| k8s.io/client-go v0.32.1 | |
| k8s.io/api v0.31.5 | |
| k8s.io/apimachinery v0.31.5 | |
| k8s.io/apiserver v0.31.5 | |
| k8s.io/client-go v0.31.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no no, I don't know how this happened, some dep must have updated these
all I did was go get -u k8s.io/[email protected] on the k8s.io packages. Not sure how it forced 0.32 for some of them
in any case, I updated the PR
12ad9e3 to
d2c2617
Compare
d2c2617 to
620df66
Compare
|
/lgtm I think this looks good! If any extra hands are needed, I'm happy to help on the 1.32 bump. |
|
@theobarberbany: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
I've raised #802
|
This does not include changes to cluster since there were no differences for it in kubernetes/kubernetes between 1.31.2 and 1.31.5.