Update verify-all.sh: added $t to explicitly tell which script had an issue during a failed test

[TheInvincibleRalph]

What type of PR is this?
/fixed bugs

What this PR does / why we need it:

This PR explicitly tells which script has an issue in a failed test

Which issue(s) this PR fixes:
Fixes #3282

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: TheInvincibleRalph / name: TheInvincible (08cdd17, c2af30b, e38fde2, 12a450b)

[k8s-ci-robot]

Welcome @TheInvincibleRalph!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @TheInvincibleRalph. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[youngnick]

/ok-to-test

Thanks for this @TheInvincibleRalph, this is a good start!

I think the key thing we wanted to see here is a summary at the bottom of all the failed tests, listed by script filename - that way, when troubleshooting CI failures, we can scroll to the bottom and see what to look for.

[TheInvincibleRalph]

/ok-to-test

Thanks for this @TheInvincibleRalph, this is a good start!

I think the key thing we wanted to see here is a summary at the bottom of all the failed tests, listed by script filename - that way, when troubleshooting CI failures, we can scroll to the bottom and see what to look for.

Oh, I think I get now. Thank you.
I'll modify the script for that now

[TheInvincibleRalph]

I have modified the script accordingly, @youngnick.

[TheInvincibleRalph]

hack/verify-all.sh: line 84: FAILED_TESTS: unbound variable
make: *** [Makefile:113: verify] Error 1
+ EXIT_VALUE=2
+ set +o xtrace

@youngnick, does this meet your expectation?

[youngnick]

Uh, it will be great, but the "unbound variable error" is because the variable is defined as FAILED_TEST, but used as FAILED_TESTS, note the S.

Once that's in, I think this LGTM, but will need @robscott review as well.

[TheInvincibleRalph]

Uh, it will be great, but the "unbound variable error" is because the variable is defined as FAILED_TEST, but used as FAILED_TESTS, note the S.

Once that's in, I think this LGTM, but will need @robscott review as well.

Ooops. I'll fix that now. Thank you

[robscott]

Thanks @TheInvincibleRalph!

/lgtm
/approve
/ok-to-test

[robscott]

/release-note-none

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, TheInvincibleRalph

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment