Skip to content

hack/verify-all should output the specific tests that failed #3282

@robscott

Description

@robscott

What would you like to be added:
When a test fails in hack/verify-all.sh, we should output the failed tests at the end of the run.

Why this is needed:
Debugging test logs is very complicated. For example, consider this recent failure where the output looked like this:

�[0;32mSUCCESS: hack/../hack/verify-yamllint.sh �[0m
make: *** [Makefile:113: verify] Error 1

The actual problematic logs were:

level=warning msg="[config_reader] The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`."
conformance/tests/backendtlspolicy-normative.go:22: File is not `goimports`-ed with -local sigs.k8s.io/gateway-api (goimports)
	"k8s.io/apimachinery/pkg/types"
�[0;31mTest FAILED: hack/../hack/verify-golint.sh �[0m

It would be great to at least show the specific script that failed closer to the final output so it's more clear why make verify failed.

Metadata

Metadata

Labels

good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions