-
Notifications
You must be signed in to change notification settings - Fork 621
conformance: Remove already deleted option RestClient #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conformance: Remove already deleted option RestClient #2265
Conversation
The below PR remove RestClient option in suite.Options, but the same is not remove in Conformance Profile file, probably it's overlooked because of the build tag (e.g. experiment). Relates: kubernetes-sigs#2241 Signed-off-by: Tam Mach <[email protected]>
|
Hi @sayboras. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mlavacca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @sayboras!
/approve
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, mlavacca, sayboras The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @sayboras! /lgtm |
What this PR does / why we need it:
To avoid compile issue if the experiment tag is enabled.
Which issue(s) this PR fixes:
The below PR remove RestClient option in suite.Options, but the same is not remove in Conformance Profile file, probably it's overlooked because of the build tag (e.g. experiment).
Relates: #2241
Does this PR introduce a user-facing change?: