conformance: remove RESTClient in suite.Options, use interface where possible #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…possible We can use the Clientset to get a RESTClient
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
howardjohn
approved these changes
Jul 27, 2023
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, michaelbeaumont The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
Thanks @michaelbeaumont! /lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
sayboras
added a commit
to sayboras/gateway-api
that referenced
this pull request
Aug 6, 2023
The below PR remove RestClient option in suite.Options, but the same is not remove in Conformance Profile file, probably it's overlooked because of the build tag (e.g. experiment). Relates: kubernetes-sigs#2241 Signed-off-by: Tam Mach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/area conformance
What this PR does / why we need it:
Simplifies the
suite.Optionsinterface, we can use theClientsetto get aRESTClient.Does this PR introduce a user-facing change?: