generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 206
chore(conformance): Add timeout configuration #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 11 commits into
kubernetes-sigs:main
from
SinaChavoshi:inf_pool_tests_3
May 13, 2025
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fc3ee1e
Add inferencepool_lifecycle test.
SinaChavoshi ba677ac
Resolve setup issues and enable InferencePool test
SinaChavoshi 3ff24a1
removed todo comment in helper.go
SinaChavoshi 2dad18d
Add InferencePoolLifecycle test
SinaChavoshi 0052a23
update comments in helper.go
SinaChavoshi b419259
remove Conformanc.go from log message
SinaChavoshi f54b575
Remove lifecycle test.
SinaChavoshi 91b053b
Removed unused helper methods ( inference pool must have selector & m…
SinaChavoshi e4c18d5
Set timeout values as constant
SinaChavoshi 36073dd
Merge branch 'main' into inf_pool_tests_3
SinaChavoshi cd042fe
change timeout.go to timing.go
SinaChavoshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| Copyright 2025 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package config | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| // Import the upstream Gateway API timeout config | ||
| gatewayconfig "sigs.k8s.io/gateway-api/conformance/utils/config" | ||
| ) | ||
|
|
||
| // InferenceExtensionTimeoutConfig embeds the upstream TimeoutConfig and adds | ||
| // extension-specific timeout values. | ||
| type InferenceExtensionTimeoutConfig struct { | ||
| // All fields from gatewayconfig.TimeoutConfig will be available directly. | ||
| gatewayconfig.TimeoutConfig | ||
|
|
||
| // InferencePoolMustHaveConditionTimeout represents the maximum time to wait for an InferencePool to have a specific condition. | ||
| InferencePoolMustHaveConditionTimeout time.Duration | ||
|
|
||
| // InferencePoolMustHaveConditionInterval represents the polling interval for checking an InferencePool's condition. | ||
| InferencePoolMustHaveConditionInterval time.Duration | ||
|
|
||
| // GatewayObjectPollInterval is the polling interval used when waiting for a Gateway object to appear. | ||
| GatewayObjectPollInterval time.Duration | ||
| } | ||
|
|
||
| func DefaultInferenceExtensionTimeoutConfig() InferenceExtensionTimeoutConfig { | ||
| return InferenceExtensionTimeoutConfig{ | ||
| TimeoutConfig: gatewayconfig.DefaultTimeoutConfig(), | ||
| InferencePoolMustHaveConditionTimeout: 300 * time.Second, | ||
| InferencePoolMustHaveConditionInterval: 10 * time.Second, | ||
| GatewayObjectPollInterval: 5 * time.Second, | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.