Skip to content

Conversation

@SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented May 8, 2025

Refactor the code to add specific timeout configuration for Inference Extension.

Adding local run results with cd042fe:

=== NAME  TestConformance/InferencePoolAccepted
    apply.go:279: 2025-05-13T21:59:04.137493549Z: Deleting httproute-for-inferencepool-accepted HTTPRoute
    apply.go:279: 2025-05-13T21:59:04.243899882Z: Deleting inferencepool-basic-accepted InferencePool
    apply.go:279: 2025-05-13T21:59:04.344676992Z: Deleting infra-backend-v1-deployment Deployment
--- PASS: TestConformance (127.63s)
    --- PASS: TestConformance/InferencePoolAccepted (121.44s)
        --- PASS: TestConformance/InferencePoolAccepted/InferencePool_should_have_Accepted_condition_set_to_True (120.06s)
PASS
ok    

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 8, 2025
@netlify
Copy link

netlify bot commented May 8, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit cd042fe
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/6823c07768a1560009840fb7
😎 Deploy Preview https://deploy-preview-795--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 9, 2025
@danehans
Copy link
Contributor

@SinaChavoshi can you help me understand why the InferencePoolLifecycle test is required for Gateway conformance? After the initial InferencePoolAccepted() test was added, I was expecting to see additional tests such as:

  1. An InferencePool surfaces the "ResolvedRefs" condition type.
  2. An InferencePool surfaces the expected condition type and values when referenced by multiple Gateways.
  3. Etc..

@SinaChavoshi
Copy link
Contributor Author

SinaChavoshi commented May 12, 2025

@SinaChavoshi can you help me understand why the InferencePoolLifecycle test is required for Gateway conformance? After the initial InferencePoolAccepted() test was added, I was expecting to see additional tests such as:

  1. An InferencePool surfaces the "ResolvedRefs" condition type.
  2. An InferencePool surfaces the expected condition type and values when referenced by multiple Gateways.
  3. Etc..

That is a fair point, I was setting up the tests based on the proposed test list here , though I completely agree that inference pool accepted and lifecycle are redundant. I will remove the lifecycle and limit the PR to refactoring to resolve TODOs.

The follow up PRs that I have queued up ( #807 - HTTPRoute status with non-matching InferencePool & #815 - InferencePool status with non-existent EPP service ) are more inline with 1 & 2, I will add specific coverage for 1 & 2 as you mentioned above as well. Added additional test cases 5 & 6 in proposal to cover the two cases mentioned above.

Also note specifically for #807 currently inference pool does not publish a status directly see - Proposal: Add Explicit Status Conditions to InferencePool API Spec #806 hence I checked the status on HTTPRoute instead of the inferencePool.

@SinaChavoshi SinaChavoshi changed the title feat(conformance): Add InferencePoolLifecycle test feat(conformance): Add timeout configuration May 12, 2025
@SinaChavoshi
Copy link
Contributor Author

Update the PR title and description as it no longer contains the new lifecycle test addition. The PR is now limited to refactoring the code to add timeout configuration ( to resolve TODO from previous PR )

@SinaChavoshi SinaChavoshi changed the title feat(conformance): Add timeout configuration chore(conformance): Add timeout configuration May 12, 2025
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SinaChavoshi!

This LGTM other than one tiny nit.

@kfswain
Copy link
Collaborator

kfswain commented May 13, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, robscott, SinaChavoshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1f62b02 into kubernetes-sigs:main May 13, 2025
8 checks passed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request May 14, 2025
* Add inferencepool_lifecycle test.

* Resolve setup issues and enable InferencePool test

* removed todo comment in helper.go

* Add InferencePoolLifecycle test

* update comments in helper.go

* remove Conformanc.go from log message

* Remove lifecycle test.

* Removed unused helper methods ( inference pool must have selector & must be deleted)

* Set timeout values as constant

* change timeout.go to timing.go
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request May 14, 2025
* Add inferencepool_lifecycle test.

* Resolve setup issues and enable InferencePool test

* removed todo comment in helper.go

* Add InferencePoolLifecycle test

* update comments in helper.go

* remove Conformanc.go from log message

* Remove lifecycle test.

* Removed unused helper methods ( inference pool must have selector & must be deleted)

* Set timeout values as constant

* change timeout.go to timing.go
kaushikmitr pushed a commit to kaushikmitr/llm-instance-gateway that referenced this pull request May 15, 2025
* Add inferencepool_lifecycle test.

* Resolve setup issues and enable InferencePool test

* removed todo comment in helper.go

* Add InferencePoolLifecycle test

* update comments in helper.go

* remove Conformanc.go from log message

* Remove lifecycle test.

* Removed unused helper methods ( inference pool must have selector & must be deleted)

* Set timeout values as constant

* change timeout.go to timing.go
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 11, 2025
* Add inferencepool_lifecycle test.

* Resolve setup issues and enable InferencePool test

* removed todo comment in helper.go

* Add InferencePoolLifecycle test

* update comments in helper.go

* remove Conformanc.go from log message

* Remove lifecycle test.

* Removed unused helper methods ( inference pool must have selector & must be deleted)

* Set timeout values as constant

* change timeout.go to timing.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants